01:04 <+bridge_> <alw5> didnt he leave because heinrich?
01:21 <+bridge_> <gorp> either that or coincidence
04:22 <+bridge_> <gorp_tw> clickable names in chat resolves a lot of things about tab navigation
04:22 <+bridge_> <gorp_tw> doesn't need autocomplete menu
08:59 <+bridge_> <Assa> Robyt just pushed > 1000 LOC yesterday in multiple commits 😆
09:00 <+bridge_> <totar> it's just moving code tho?
09:00 <+bridge_> <Assa> partly, but not everything
09:29 <+bridge_> <byfox> Hello everyone, I'd like to know how to eliminate this error when running the sent binary...
09:29 <+bridge_> <byfox> 
09:29 <+bridge_> <byfox> ⁨```
09:29 <+bridge_> <byfox> cmake -DCMAKE_BUILD_TYPE=Release -GNinja ..
09:29 <+bridge_> <byfox> ninja
09:29 <+bridge_> <byfox> ```⁩
09:29 <+bridge_> <byfox> https://cdn.discordapp.com/attachments/293493549758939136/1467799036579942582/image.png?ex=6981b1e0&is=69806060&hm=104a031ed4b237166a5c15ddc4dc5fc09af93155a740bbab95205937a913156a&
10:12 <+bridge_> <k0rae> is this just not true?
10:12 <+bridge_> <k0rae> https://cdn.discordapp.com/attachments/293493549758939136/1467809909822329006/image.png?ex=6981bc01&is=69806a81&hm=ac153decdcc8d53940f6ccef3ab004b6aca52d935008d5775e082629837f24e5&
10:15 <+bridge_> <k0rae> https://github.com/ddnet/ddnet-libs/tree/642cf04cd51d620787bffcfa736a05fd8a4df612/discord/linux/lib64 probably this
10:43 <+bridge_> <chairn> haven't checked the code, but it's standard C behavior so it's probably modeled on C file functions
10:58 <+bridge_> <k0rae> i’m pretty sure @chillerdragon flipped true and false some time ago and nobody changed this comment
11:24 <+bridge_> <aegisub> proving yet again that documentation is evil
11:38 <+bridge_> <inv41idu53rn4m3> Need a way for every piece of documentation to have a reference to the lines of code it is about, and then produce notifications for every piece of documentation that had its associated code change
11:47 <+bridge_> <avolicious> Clickable links like Minecraft, also with a disclaimer if you click on a link would be amazing
11:53 <+bridge_> <totar> They removed that feature 😭
11:56 <+bridge_> <totar> oh nvm its just off by default now im stupid
11:57 <+bridge_> <avolicious> Chat is very limited sadly
12:02 <+bridge_> <aegisub> ddnet should ban users for things they say in chat on private servers
12:03 <+bridge_> <melon> I suggested that before, but the maintainers were against that to prevent harmful content being spread *even faster*
12:09 <+bridge_> <avolicious> Mhm, but even with a disclaimer?
12:09 <+bridge_> <avolicious> Copying a link from F1 or clicking on it, does it make such a difference?
12:10 <+bridge_> <avolicious> The client could only enable this link feature for known communities, would also limit harmful content
12:10 <+bridge_> <melon> https://github.com/ddnet/ddnet/issues/7851
12:12 <+bridge_> <melon> I didn't feel like it's worth pushing towards this with both Roby and Heinrich being against it xd
12:12 <+bridge_> <melon> I didn't feel like it's worth pushing with both Roby and Heinrich being against it xd
12:12 <+bridge_> <melon> I didn't feel like it's worth pushing with both Roby and Heinrich against it xd
12:18 <+bridge_> <totar> Id merge if it was clean
12:19 <+bridge_> <learath2> I'm not completely against doing it a-la discord with the warning for unknown domains
12:25 <+bridge_> <robyt3> If you can confidently avoid arbitrary code execution :justatest:
12:26 <+bridge_> <totar> Where is the risk for that?
12:28 <+bridge_> <aegisub> the current implementation of ⁨`open_link`⁩ goes through ⁨`ShellExecuteExW`⁩
12:28 <+bridge_> <totar> :stare:
12:42 <+bridge_> <totar> SDL_OpenUrl is perfectly safe if you only allow https/http
12:48 <+bridge_> <totar> actually would be cool if you also allowed ddnet: you could send a redirect link in chat in a convoluted way
12:50 <+bridge_> <robyt3> It just calls ⁨`ShellExecuteW`⁩
12:51 <+bridge_> <robyt3> But it should be mostly safe from what I can tell if limited to ⁨`https://`⁩ prefixed strings, then it *only* runs an arbitrary shell handler for the https protocol
12:54 <+bridge_> <totar> it does
12:54 <+bridge_> <totar> ``WIN_UTF8ToStringW``
12:54 <+bridge_> <totar> you have to call ``ShellExecuteW`` eventually
13:07 <+bridge_> <totar> it seems ``ShellExecuteW`` is actually quite safe
13:07 <+bridge_> <totar> it just has a scary name
13:08 <+bridge_> <totar> unless you're super stupid the attack surface is not big
13:14 <+bridge_> <totar> the biggest risk, if you don't enforce http(s) seems to be that an attacker could get a victim to download a file, and then by clicking a link in the ddnet chat the file could be executed.
13:15 <+bridge_> <charlie_kl> Help, I added the texture but it doesn't show up in DDNet
13:15 <+bridge_> <charlie_kl> pls
13:15 <+bridge_> <totar> but if you assume the install is fresh then you can't get ACE/RCE even with passing a string to ``ShellExecuteW``
13:16 <+bridge_> <totar> it doesn't let you supply arguments to things it opens
13:17 <+bridge_> <totar> unless you find a zero day in the scheme handler of one of the windows binaries
13:18 <+bridge_> <totar> which are probably less hardened than browsers
13:18 <+bridge_> <chillerdragon> @k0rae: comment wrong
13:18 <+bridge_> <chillerdragon> U want to send fix ?
13:18 <+bridge_> <chillerdragon> I can click links btw
13:19 <+bridge_> <chillerdragon> Gnome terminal supports it
13:21 <+bridge_> <totar> actually for a long time discord let you click links that weren't http(s):: I miss that feature
13:21 <+bridge_> <totar> it was really useful for steam invites
13:21 <+bridge_> <totar> I wonder what their reason for removing it was
13:30 <+bridge_> <Assa> just open the link in the default browser right? :justatest:
13:30 <+bridge_> <Assa> nah I am also against it, this  just invites ad spam
13:43 <+bridge_> <Assa> you know how much I am against this? I am thinking about adding another filter to chatmessages scanning for links and warning or muting users who send stuff like this
13:44 <+bridge_> <kebscs> Clickable links before accounts or chat filter is definetly not a good idea
13:45 <+bridge_> <totar> I'd still merge
13:46 <+bridge_> <totar> you might as well ban all communication between users if you think making navigating to a link will cause significant issues
13:46 <+bridge_> <totar> you might as well ban all communication between users if you think making navigating to a link easier will cause significant issues
13:47 <+bridge_> <totar> god forbid we make a chat system that doesn't make it phyiscally impossible to do something bad
13:47 <+bridge_> <chillerdragon> Removing chat would be great
13:47 <+bridge_> <chillerdragon> It’s mostly toxic Russian kids anyways these days
13:52 <+bridge_> <avolicious> Finally
14:31 <+bridge_> <chillerdragon> when unmute irc
14:34 <+bridge_> <chillerdragon> yo @robyt3 how bad is it to read the result of a pending IJob? xd https://github.com/ChillerDragon/antibob/blob/e9b46bb622d35757ba65e37d991d7cfc7bbb7a54/src/antibob/bob/antibot_player.cpp#L161
16:00 <+bridge_> <totar> it's exactly as thread safe as any other datarace?
16:27 <+bridge_> <robyt3> That's not thread-safe, see https://github.com/ddnet/ddnet/blob/0b503e388c381e5131cfdd25a2f893a9c2a36d31/src/engine/shared/jobs.h#L80-L89
16:40 <+bridge_> <learath2> Hm, so we need to use a very strict regex, parsing URLs is harder than most people think, but if we restrict it to a strict subset of URLs it's not too bad. Then all we need to ensure is that the protocol part is http or https or maybe ddnet
17:21 <+bridge_> <chillerdragon> I hope as long as I only write to the variable from the main thread I should be fine
17:21 <+bridge_> <chillerdragon> @learath2: when do we get irc back
19:09 <+bridge_> <remakepower> Did we have a plan for demo version 7
21:04 <+bridge_> <robyt3> I don't think so, but I'd like the next change to the demo format to make it versatile enough so that we don't have to change it again
22:55 <+bridge_> <gorp_tw> Can we export demos without leaking whispers?
22:55 <+bridge_> <gorp_tw> (I know you can disable chat outright)