00:52 <+bridge_> @brokecdx: this channel is one of the best ways. And also just say what you need directly otherwise it takes long .\_. 01:14 <+bridge_> @swarfey do you know how well two Clients work in the same process? they seem to fight over the event queue or something because stuff just breaks on all but one client at a time 01:14 <+bridge_> might have to check the async stuff later 01:14 <+bridge_> it could also be my code that's blocking too much but im not sure 01:15 <+bridge_> two clients should work pretty fine 01:16 <+bridge_> i only started noticing problems with >10 tees. for my discord bridge i have a process for every single server to avoid lags like that 01:27 <+bridge_> ah shiet 01:27 <+bridge_> okay, might be the same thing then 06:57 <+bridge_> no apparently 09:16 <+bridge_> i really wating this one https://github.com/ddnet/ddnet/pull/10969 09:16 <+bridge_> can someone say what happens with that? 09:51 <+ChillerDragon> i really waiting this one 09:51 <+ChillerDragon> https://github.com/ddnet/ddnet/pull/10399 09:51 <+ChillerDragon> https://github.com/ddnet/ddnet/pull/10964 10:35 <+ChillerDragon> so what is it now? @brokecdx 10:35 <+ChillerDragon> dont edge me like that 11:32 <+bridge_> Is this rendering bug? It's supposed to be lowercase `l` but it has a horizontal bar above it 11:32 <+bridge_> https://cdn.discordapp.com/attachments/293493549758939136/1456958417800269897/image.png?ex=695a41c3&is=6958f043&hm=303d9cf90500df400c41a1c09c421e41fcb7c096df784ab5e1eb6d98b685584d& 11:53 <+bridge_> mapname has underscore 11:53 <+bridge_> the line spacing does seem a bit crammed though 11:53 <+bridge_> oooh xd 11:54 <+bridge_> it'd be nice if ddnet servers sent info in a more structured way than ascii art motd though 11:54 <+bridge_> With more line spacing the border on the left side wouldn't align anymore though 11:54 <+bridge_> Yeah, we shouldn't have to use ASCII art for this 11:54 <+bridge_> yeah :twintri: 11:55 <+bridge_> #2875 11:55 <+bridge_> https://github.com/ddnet/ddnet/issues/2875 12:11 <+bridge_> how do i know which cl_prediction_margin i should use? where can i see info on my lagspikes? 12:29 <+bridge_> cant you just login into your dsicord account for a quick chat :gTastyPepeCry: 12:50 <+bridge_> its possible to skip this main menu? i always press "play" never use this menu. back my old days. 12:50 <+bridge_> https://cdn.discordapp.com/attachments/293493549758939136/1456977957636804632/image.png?ex=695a53f6&is=69590276&hm=24f198f7cf205f62aebe46ebc3d992e6e6b01f1d0c1766b2343a3db4b063648e& 12:50 <+bridge_> its possible to skip this main menu? i always press "play" never use this menu. plz back my old days. 12:50 <+bridge_> https://cdn.discordapp.com/attachments/293493549758939136/1456977957636804632/image.png?ex=695a53f6&is=69590276&hm=24f198f7cf205f62aebe46ebc3d992e6e6b01f1d0c1766b2343a3db4b063648e& 12:52 <+ChillerDragon> @triki -,- 12:52 <+ChillerDragon> f1 12:52 <+ChillerDragon> "menu" 12:52 <+ChillerDragon> tab 12:52 <+ChillerDragon> `cl_skip_start_menu` 12:52 <+ChillerDragon> some configs are not named in the most obvious way but i still feel often ppl did not even look for 1 second :D 12:53 <+ChillerDragon> @Brokecdx- no chance 12:53 <+ChillerDragon> u want private chat or what? 12:53 <+ChillerDragon> i can offer you plenty private chat rooms but why dont you quickly say what you need right here? 12:56 <+bridge_> i just didnt know it can be exist. 12:57 <+ChillerDragon> wire: @zillyhuhn, matrix: @chillerdragon:matrix.org, email: chillerdragon@gmail.com, irc: https://webchat.quakenet.org/ #ddnet, xmpp: chillerdragon@yax.im 12:57 <+ChillerDragon> @Brokecdx- 12:57 <+ChillerDragon> or sign up https://chat.zillyhuhn.com/ with code nimrocks 12:58 <+ChillerDragon> or best option: just say it here xd 12:58 <+ChillerDragon> can also whisper me up in game i am planning to farm kog points for at least 10 hours today 13:09 <+bridge_> gg 13:10 <+bridge_> FCK i alt +f4'd the wrong client 13:11 <+bridge_> why gmail? isnt proton better 13:19 <+ChillerDragon> proton banned all my accounts 13:20 <+ChillerDragon> without a way to restore them or recover the accounts that i signed up with third parties using my proton mails 13:21 <+ChillerDragon> no sure what would make proton better 13:38 <+bridge_> <01000111g> why is that 14:28 <+bridge_> Thanks 🙂 15:36 <+bridge_> We do have controller support now right? 15:36 <+bridge_> https://cdn.discordapp.com/attachments/293493549758939136/1457019727263301805/image.png?ex=695a7add&is=6959295d&hm=211b0dca6298a64f75bfb730fd532f1a99082dfd0284a0e0b16b370fc7ee715b& 15:37 <+bridge_> I think menus were not properly accessible with controllers 16:53 <+bridge_> can we get https://github.com/ddnet/ddnet/pull/11484 merged 16:53 <+bridge_> always check in GUI settings aswell, I found it on my first run and turned it on :P 16:54 <+bridge_> checks arent failing and its been reviewed 16:54 <+bridge_> https://cdn.discordapp.com/attachments/293493549758939136/1457039403749871659/waterfox_MNdmthBPBR.png?ex=695a8d30&is=69593bb0&hm=c1fbab83ceb3066558e85345de32181df64415a6c735433fc4a4708662eda97d& 16:54 <+bridge_> and the issue with commit author information is fixed 16:54 <+bridge_> so can be merged..? 16:54 <+bridge_> idk why thats an issue in the first place 16:55 <+bridge_> i guess since it doesnt add +1 commit to https://github.com/ddnet/ddnet/graphs/contributors 16:55 <+bridge_> it does 16:56 <+bridge_> well idk then 16:56 <+bridge_> its just not linked to a github account, and i guess the author didnt care about that 16:57 <+bridge_> It seems like an issue that the contributor might want to be aware of. If it's not linked you also can't find the author to blame as quickly. 16:57 <+bridge_> He isn't the first person linking the wrong account to a commit or something :justatest: 16:58 <+bridge_> and he had few prs before 16:58 <+bridge_> and the email can be linked anytime 16:58 <+bridge_> You can't retroactively change the author information without rewriting history or revert+redo 16:59 <+bridge_> not by changing the commit 16:59 <+bridge_> just adding the email from commit to gh acc 16:59 <+bridge_> its all fixed 16:59 <+bridge_> can we merge it now 16:59 <+bridge_> 😭 16:59 <+bridge_> If there's no email in the commit there's nothing to link 17:00 <+bridge_> watch assa make a comment `i` -> `ClientId` and we wait another 2 weeks for that 17:00 <+bridge_> ik, but there was one 17:01 <+bridge_> when you already know, that I am going to do this, why didn't you do it for me? 17:01 <+bridge_> not a meaningful change to me 17:01 <+bridge_> and that person seem to be somewhat inactive on github to be changing stuff that dont really matter 17:01 <+bridge_> so i thought its going to be faster merge 17:02 <+bridge_> so i thought its going to be faster merge for a good feature 17:03 <+bridge_> My only problem is, that this PR happened over the festive days and I wasn't as active - we only have about 3 active maintainers currently, who do reviews 17:03 <+bridge_> btw can be checked by adding `.patch` at the end of link, and it shows unparsed git commit info 17:04 <+bridge_> you could argue about the definition of active here 🙂 17:05 <+bridge_> e.g. 17:07 <+bridge_> @essigautomat you use work email for commits btw 17:08 <+bridge_> I am still waiting for the swat team to rush me, I am very easily findable 17:08 <+bridge_> :kek: 17:20 <+ChillerDragon> @Assa its a thing be careful xd https://www.youtube.com/watch?v=FIEwcTKUFCA 17:20 <+bridge_> is this US? 17:20 <+ChillerDragon> i think this is germany 17:21 <+ChillerDragon> open source swattin 17:23 <+bridge_> Oh maybe I get a new door then :brownbear: 17:28 <+bridge_> Maybe I'll just preemptively call the police and just tell them that this might happen 17:48 <+bridge_> hey git pros, what is the best way to make PRs that are based on other unmerged PRs? I have created a PR for the /teamleader command 2 weeks ago (unmerged) and have in the meantime created a new branch on top of that feature to add it to the player netflags. 17:48 <+bridge_> if i send a PR for that new branch to ddnet right now there will be 6 commits from the previous PR and only 1 new commit that is actually meant for the new PR 17:50 <+bridge_> or do i rebase and drop the old PR commits? then the build checks will fail though 17:51 <+bridge_> if you have 2 features, one of which depends on it, you can create 1 pr, and 1 draft pr 17:51 <+bridge_> where the commits come from shouldnt matter as long as they are there and attribution is correct 17:51 <+bridge_> if you have 2 features, one of which depends on it, you can create 1 pr, and 1 draft pr. 17:51 <+bridge_> where the commits come from shouldnt matter as long as they are there and attribution is correct 17:51 <+bridge_> if you have 2 features, one of which depends on the other, you can create 1 pr, and 1 draft pr. 17:51 <+bridge_> where the commits come from shouldnt matter as long as they are there and attribution is correct 18:01 <+bridge_> okay, so i should keep the 6 commits from the first PR in the second PR, right? 18:04 <+bridge_> idk how to do it when the branches are on seperate repo, you can just keep the commits on new 18:04 <+bridge_> idk how to do it when the branches are on seperate repo, you can just keep the commits on new pr and rebase when the first one gets merged 18:05 <+bridge_> Yes, that called a "stacked PR" 18:05 <+bridge_> Yes, that's called a "stacked PR" 18:06 <+bridge_> okay thanks 🙂 19:37 <+bridge_> I don't find giving all the loop indices names very productive, unless multiple nested loops are involved 19:38 <+bridge_> Not all that important, I just wanted everyone to know that 😛 19:54 <+bridge_> easy PRs and doesnt make readability worse 19:55 <+bridge_> i much prefer ClientId over i everywehre we do it because to people who dont know we loop over all client ids alot (me in the past) can get confused 19:56 <+bridge_> the loop in question is i < MAX_CLIENTS, i think its clear in that case 19:56 <+bridge_> the loops can be very long 19:57 <+bridge_> in some cases 19:57 <+bridge_> regardless i see free pr when i see i 19:57 <+bridge_> regardless i see free pr when i see `i` 19:59 <+bridge_> You shouldn't look at PRs as collectibles 😄 20:00 <+bridge_> I would argue `m_apClients[i]` is quite obvious tbf, even in a massive loop, like what else would you use to index an array of client pointers but a client id? 20:01 <+bridge_> What's next, you're not a better contributor if you have more merged PRs? 20:01 <+bridge_> As said, not all that important, I just wanted to point out that it's not all that helpful to do 20:03 <+bridge_> Now because of typo workflow I can't do PRs which fix typos :feelsbadman: 20:06 <+bridge_> @learath2 could you take a look at 20:06 <+bridge_> i think you got tagged here by roby before 20:06 <+bridge_> i think you got tagged in it by roby before 20:11 <+bridge_> Could you ping me tomorrow about this? I'll try to keep it in mind too 20:11 <+bridge_> sure, thank you 21:34 <+bridge_> hi guys, where did h-m-h go? It's just that he seems to have made a huge contribution to the development of ddnet before. 21:34 <+bridge_> Hellou :3 21:37 <+bridge_> For me the naming convention is about clarity and code quality. `i` for index can mean anything, ClientId is more descriptive and I don't need to know about the loop in order to know what ClientId is. One day we may drop the rule that allows index variables like this in the first place 21:38 <+bridge_> Applying rules to the code is a good thing, because C++ gives you way to much freedom in how you can write code and easily allows you to write shitcode 21:38 <+bridge_> Applying rules to the code is in general good thing, because C++ gives you way to much freedom in how you can write code and easily allows you to write shitcode 21:39 <+bridge_> Applying rules to the code is in general a good thing, because C++ gives you way to much freedom in how you can write code and easily allows you to write shitcode 21:39 <+bridge_> not sure, but seems like his last PR was 8 years ago, so you're kinda late 21:41 <+bridge_> Did he just suddenly disappear? 21:41 <+bridge_> imo faster merge > `i`->`ClientId` in an obvious context 21:41 <+bridge_> I'm just digging out the depths of the ddnet for an iceberg 21:42 <+bridge_> idk i havent been around that long time ago, but from his github acc he just worked on other projects instead 21:42 <+bridge_> the issue is not that it easily allows you to write shitcode. but that the easiest code to write is shitcode 21:47 <+bridge_> He turns out to be the creator of Weylus. It's something like SpaceDesk, but open source 22:06 <+bridge_> Allah willing we never do, long verbose names are propaganda by computer scientists who last thought about coding in 1857 22:11 <+bridge_> <0xdeen> `i` is the best loop variable name though. If you want long names, use Java 😄 22:14 <+bridge_> we got arguing over i in for loop before accounts 22:15 <+bridge_> and also apparently about the use of checkboxes 22:15 <+bridge_> jeepers 22:16 <+bridge_> @swarfey Currently, any call to Client.Disconnect causes the lib to think it timed out, since there is a non-cancellable(?) interval in the connect fn 22:16 <+bridge_> i can check again though, also weird that connect is lowercase xd 22:19 <+bridge_> https://github.com/swarfeya/teeworlds-library-ts/blob/20579f8f3956bcbd4366fe52be438d8d208329b7/lib/client.ts#L498-L507 Ofc, `this.lastRecvTime` will not be updated after we send `this.SendControlMsg(4)` since the server immediately knows we want to disconnect 22:20 <+bridge_> ran some scripts 22:20 <+bridge_> and the ai checkbox was described in only 3% of the prs 22:20 <+bridge_> crazy number 22:20 <+bridge_> instead of waiting around for this (and erroneously saying we have timed out) this interval should probably be stored somewhere so the disconnect can clear it 22:20 <+bridge_> considering ai usage is like 85% based on surveys 22:28 <+bridge_> I am 100% in agreement 22:40 <+bridge_> antiblocker system 22:40 <+bridge_> https://cdn.discordapp.com/attachments/293493549758939136/1457126382386544742/image.png?ex=695ade31&is=69598cb1&hm=9ff121909ad1ec10a798cb70764f766dbc87ed00e866db9786fbd6bbc62d2315& 22:49 <+bridge_> blocker win( 22:49 <+bridge_> https://cdn.discordapp.com/attachments/293493549758939136/1457128797320118282/image.png?ex=695ae071&is=69598ef1&hm=ecb56a0875576c40e9f5d66c32f24abeab713c62e3ea1d0dc3cc8d1d0cc8ed2a& 22:57 <+bridge_> why are you posting in #developer 22:58 <+bridge_> skull 22:59 <+bridge_> perma ban dieoska :P 23:00 <+bridge_> cool now we have official tas in ddnet prs 23:04 <+bridge_> :kek: again 23:06 <+bridge_> this one seems to actually work 23:07 <+bridge_> looks like replaying inputs, not full tas 23:09 <+bridge_> yea just a replay bot 23:09 <+bridge_> the last one was just slop from claude 23:10 <+bridge_> https://ddnet.org/players/dieoska/ 23:11 <+bridge_> finished linear and decided to make tas 💔 23:11 <+bridge_> XD 23:11 <+bridge_> bro did like 5 THINGS total