05:38 < bridge> <chillerdragon> Yea but that is a scope you randomly chose. Seems like personal taste. It’s not like this inconsistency is problematic somehow. I didn’t verify but I’m quite confident we already mix log\_info dbg\_msg and Console::Print in some files.
05:38 < bridge> <chillerdragon> 
05:38 < bridge> <chillerdragon> This is how we slowly but surely actually progress. Or would you also ask me to do it for the entire gamecontext.cpp file if the pr was there?
05:39 < bridge> <chillerdragon> I don’t like editing windows code. It doesn’t even compile on my machine and I have no auto complete or syntax highlight there
05:42 < bridge> <chillerdragon> I looked at the fifo can’t remove file error because I encountered it and was actively running into that branch imo it makes sense to scope my pr around that
05:43 < bridge> <chillerdragon> Maybe I should just send a few prs only premoving nitpicks. I find it so annoying that touching any code will cause reviewers to request changes in existing code.
05:44 < bridge> <chillerdragon> Such a legacy codebase minefield
11:24 < ws-client> **<ChillerDragon>** @Assa yo mr hook coll expert u here?
11:25 < ws-client> **<ChillerDragon>** the gamecore.cpp so the server side seems to use teesize + 2.0f for hook distance
11:25 < ws-client> **<ChillerDragon>** https://github.com/ddnet/ddnet/blob/3f623af0071f2c266e644e107133bfdf4ba43191/src/game/gamecore.cpp#L358
11:25 < ws-client> **<ChillerDragon>** `if(distance(pCharCore->m_Pos, ClosestPoint) < PhysicalSize() + 2.0f)`
11:25 < ws-client> **<ChillerDragon>** and the client in players.cpp seems to use teesize + 1.5f for hook distance
11:25 < ws-client> **<ChillerDragon>** https://github.com/ddnet/ddnet/blob/3f623af0071f2c266e644e107133bfdf4ba43191/src/game/client/components/players.cpp#L197
11:25 < ws-client> **<ChillerDragon>** `static constexpr float HOOK_START_DISTANCE = CCharacterCore::PhysicalSize() * 1.5f;`
11:26 < ws-client> **<ChillerDragon>** can we maybe get rid of these magic numbers and use client/server shared constants for the hook radius 
11:57 < bridge> <Assa> are you sure this is the same var?
12:02 < bridge> <Assa> go refactor gamecore without changing physics.
12:02 < bridge> <Assa> 
12:02 < bridge> <Assa> https://github.com/ddnet/ddnet/blob/3f623af0071f2c266e644e107133bfdf4ba43191/src%2Fgame%2Fgamecore.cpp#L499
12:02 < bridge> <Assa> 
12:02 < bridge> <Assa> here more magic numbers
12:05 < bridge> <Assa> so get rid of all the magic values in gamecore before complaining to me about magic values in the hook line :pepeW:
12:08 < ws-client> **<ChillerDragon>** yea no i aint gonna touch physics :D
12:08 < bridge> <Assa> exactly
12:09 < ws-client> **<ChillerDragon>** why is your url so cursed wtf
12:09 < ws-client> **<ChillerDragon>** you can just use / no need for %2F
12:10 < bridge> <Assa> because gh app
12:10 < ws-client> **<ChillerDragon>** cring
12:10 < ws-client> **<ChillerDragon>** common android L
12:10 < bridge> <Assa> 🤷🏻‍♂️ glad it exists
12:17 < ws-client> **<ChillerDragon>** this is what teero mentioned once right?
12:17 < ws-client> **<ChillerDragon>** that the hook does not start from the tees center
12:17 < ws-client> **<ChillerDragon>** https://github.com/ddnet/ddnet/blob/3f623af0071f2c266e644e107133bfdf4ba43191/src/game/gamecore.cpp#L259-L265
12:17 < ws-client> **<ChillerDragon>** as far as i can tell this is the first code that gets executed when hooking starts
12:17 < ws-client> **<ChillerDragon>** and the hook starting pos is already offset from the hooking tee's center
12:17 < ws-client> **<ChillerDragon>** bit odd if you ask me :D
12:18 < bridge> <Assa> it doesn't and this is why you can hook through corners
12:18 < ws-client> **<ChillerDragon>** oh right true
12:18 < ws-client> **<ChillerDragon>** i see i see
12:18 < ws-client> **<ChillerDragon>** i never bothered to read physics code
12:19 < bridge> <Assa> believe me, you are capable to do a PhD with hook physics
12:21 < bridge> <Assa> the fact that a retracting hook is longer than a flying one :cammostripes:
12:22 < ws-client> **<ChillerDragon>** yea im not looking forward to what is ahead of me rn
12:23 < ws-client> **<ChillerDragon>** i should just vibe code this sht
16:53 < bridge> <Assa> This seems to be a ddnet-insta issue, it always sends finish time not finished and sorts by it 🤷🏻‍♂️
17:38 < bridge> <byfox> client side problem...
18:14 < bridge> <chillerdragon> The client should sort by what it displays
18:15 < bridge> <chillerdragon> Anything else is a bug imo
20:37 < bridge> <Assa> no server side problem
20:37 < bridge> <Assa> The server sends finish times i.e. NOT FINISHED
20:38 < bridge> <Assa> and the client just doesn't show it, because you didn't merge my scoreboard update.
20:39 < bridge> <Assa> merge #11138 and it shows correctly
20:39 < bridge> <DDNet> https://github.com/ddnet/ddnet/pull/11138
21:05 < bridge> <alw5> @furo
21:05 < bridge> <alw5> day three
21:30 < bridge> <pioooooo> #11460
21:30 < bridge> <DDNet> https://github.com/ddnet/ddnet/pull/11460