00:04 < bridge> <chillerdragon> @kebscs: I usually don’t test nitpicks which is also why I think they are bad
00:04 < bridge> <chillerdragon> Imo nitpicks should be follow up prs tested by the nitpicker
00:11 < bridge> <kebscs> not even launching game once?
00:13 < bridge> <chillerdragon> Not even compiling
00:17 < bridge> <kebscs> :justatest:
00:19 < bridge> <kebscs> doesnt work on ddnet :/
00:19 < bridge> <kebscs> i tried to troll buy force_vote and change_map isnt enabled for helpers
00:19 < bridge> <louis> :banhammer:
00:20 < bridge> <kebscs> i tried to troll but force_vote and change_map isnt enabled for helpers
00:24 < bridge> <chillerdragon> Selfreport
00:43 < bridge> <kebscs> i'm just testing severity of the vulnerability 🙂
03:22 < bridge> <Ewan> @jupeyy_keks i'm looking at the code a little closer, i wanted to know how the swap chain worked in the vulkan backend
03:22 < bridge> <Ewan> 
03:22 < bridge> <Ewan> I see here that the dbg message associated with my crash has a check to see if the result of vulkan's next frame acquisition function matches a constant `VK_SUBOPTIMAL_KHR`
03:22 < bridge> <Ewan> 
03:22 < bridge> <Ewan> https://github.com/ddnet/ddnet/blob/0790cc1e1c812607017a30fcebbb74116ea53c03/src/engine/client/backend/vulkan/backend_vulkan.cpp#L2359
03:22 < bridge> <Ewan> 
03:22 < bridge> <Ewan> so i looked up the constant and quickly found this part of the vulkan tutorial <https://vulkan-tutorial.com/Drawing_a_triangle/Swap_chain_recreation>
03:22 < bridge> <Ewan> 
03:22 < bridge> <Ewan> if you look at the "Suboptimal or out-of-date swap chain" section, i see that what's written in ddnet matches their first example, but they do give two (the second being the safer/more liberal option)
03:23 < bridge> <Ewan> https://cdn.discordapp.com/attachments/293493549758939136/1432555150702284831/image.png?ex=69017a73&is=690028f3&hm=6439529b14de19dd3a4cf35772f2633a479ba7926feaed997d67c9cb85d9cfb1&
03:24 < bridge> <Ewan> i have a theory that presenting the suboptimal swap chain like the first example might do is what's causing the "crash", and we should opt to check for it on line 2347 of that file instead
03:24 < bridge> <Ewan> https://cdn.discordapp.com/attachments/293493549758939136/1432555471583318157/image.png?ex=69017ac0&is=69002940&hm=b519605ebca81e30bb773131bda82b7e2a3db636566887937a376eca6e5e5ee8&
03:25 < bridge> <Ewan> im gonna test it
03:26 < bridge> <Ewan> and also the whole block on the bottom half of that GitHub screenshot should be replaced with a dbg_assert because of the timeout protection thing
03:30 < bridge> <Ewan> i tested it and now i think it's not related at all
03:34 < bridge> <Ewan> it is probably a sdl bug
03:34 < bridge> <Ewan> :cammo:
03:39 < bridge> <Ewan> i got better output tho
03:39 < bridge> <Ewan> https://cdn.discordapp.com/attachments/293493549758939136/1432559463960809482/image.png?ex=69017e77&is=69002cf7&hm=7b897040c9332206e4733643e0541632124cbf0ccbaa361e8734a1fc872dcd5d&
03:47 < bridge> <Ewan> <https://github.com/libsdl-org/SDL/issues/13454>
03:47 < bridge> <Ewan> or it's an nvidia driver issue :feelsbadman:
03:52 < bridge> <Ewan> https://cdn.discordapp.com/attachments/293493549758939136/1432562755441000540/image.png?ex=69018188&is=69003008&hm=d58d73ee04e79c4fada59163514333a192a0aee5ab64ba2b6bc997cd6f5bb743&
03:52 < bridge> <Ewan> https://cdn.discordapp.com/attachments/293493549758939136/1432562755772223670/image.png?ex=69018188&is=69003008&hm=48351ec7a5cce3be7fe0619dbc9af1dc4cb1b4ab60c0c75954fe2f1eed203e64&
03:53 < bridge> <Ewan> https://cdn.discordapp.com/attachments/293493549758939136/1432562755441000540/image.png?ex=69018188&is=69003008&hm=d58d73ee04e79c4fada59163514333a192a0aee5ab64ba2b6bc997cd6f5bb743&
03:53 < bridge> <Ewan> https://cdn.discordapp.com/attachments/293493549758939136/1432562776957522095/image.png?ex=6901818d&is=6900300d&hm=ffc9fe35fdc36360e169fecef705838c8386b9aaf508b319e2b67cb01a8463ad&
03:53 < bridge> <Ewan> i ran the game for like 10 seconds
03:53 < bridge> <Ewan> damn