00:06 < bridge> Mb dont kill me please :pepeH: 00:06 < bridge> I pulled libtw2 and tried to build wireshark plugin 00:12 < bridge> how i do that. I dont know rust :justatest: 01:34 < bridge> Yes that much is obvious from the screenshot. But why? What are you wiresharking? 01:35 < bridge> What you did looks good. No idea what the issue is. Maybe wrong rust version. Not sure if anyone ever tried to build that on windows you can try pinging Heinrich but he will read this eventually anyways I think 01:47 < bridge> what toolchain are you using? msvc mangles symbol names differently from gcc and clang so it would expect different function names 01:59 < bridge> don't forget the world depends on #7691 01:59 < bridge> https://github.com/ddnet/ddnet/pull/7691 03:02 < bridge> @mbvxoxo give me another idea 08:14 < bridge> the world depends on monotonic buffer resource 08:23 < bridge> true 08:23 < bridge> @tela what macos ver u on 08:32 < bridge> @mpft if its for me i would merge it but i want atleast another one to agree 08:33 < bridge> yea 08:33 < bridge> nobody looking at it 08:33 < bridge> i gave my 🦭 of aproval 08:33 < bridge> seal 08:33 < bridge> i love seals 08:33 < bridge> some ppl say my dog looks like a seal 08:33 < bridge> but seals are just water dogs 08:34 < bridge> give me an idea 08:34 < bridge> xd 08:36 < bridge> @mpft did u see deen comment on my pr 08:36 < bridge> should i make CHeap thread safe 08:36 < bridge> Yes 08:36 < bridge> the old way isnt and this isnt 08:36 < bridge> that would be sick for when i have another go at async skins 08:36 < bridge> but whats the point if the 🍎 is holding me back 08:36 < bridge> i think when i do it again i will just batch them and not try and have them load in the bg with the game xd 08:36 < bridge> no matter how i do that i will still get micro stutters 08:37 < bridge> bcs it has to wait to upload to the gpu at an irregular time 08:37 < bridge> maybe it isn't 08:37 < bridge> depends on how deen feels about dropping host compilation support for already very old macos 08:38 < bridge> who is Shereef Marzouk 08:39 < bridge> idk 08:39 < bridge> why u ask 08:39 < bridge> but the ci on gh is using macos-latest iirc XD 08:39 < bridge> yea 08:39 < bridge> he's (c) at the top of ddracechat.cpp 08:39 < bridge> maybe other files 08:39 < bridge> never heard the real name before 08:39 < bridge> i'm sure you can still run the binary compiled by latest macos on <14 08:40 < bridge> depends on how deen feels about dropping compilation host support for already very old macos 08:45 < bridge> Why? 08:45 < bridge> Greyfox 08:45 < bridge> @learath2 read deen comment 08:45 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1188024670209970296/image.png?ex=65990531&is=65869031&hm=f773a7eddc3ce343ac732bf70e93fbbcb636c9143ad1b289635472dc852dff71& 08:46 < bridge> as long as CHeap doesn't have bad single thread perf because it's thread safe. which i can't see happening anyway 08:46 < bridge> did u check my pr yet 08:46 < bridge> https://github.com/ddnet/ddnet/pull/7692 08:46 < bridge> cheap is rarely used too 08:46 < bridge> only for localisation and another thing 08:46 < bridge> I think it should be made thread safe at the point of use. That's how most containers are unless they are specifically crafted to be threadsafe usually locklessly 08:46 < bridge> apparently macos comes with gcc 13 in github ci? 08:46 < bridge> can se use that? 08:47 < bridge> https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md 08:47 < bridge> i see 08:48 < bridge> Do we even use it from multiple threads ever anyway? 08:48 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1188025442486202478/image.png?ex=659905e9&is=658690e9&hm=597366f23ba28f04d989a4ca3889afd14e1e86d9b5b607b31631e073826a6862& 08:49 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1188025488459960401/image.png?ex=659905f4&is=658690f4&hm=c9395915ae06b3ebf59bea22fd9b0b500dd4f9e18d21bca79b5f102e687c2777& 08:49 < bridge> those are the uses i found 08:49 < bridge> is the serverbrowser MT? 08:50 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1188025875376128040/image.png?ex=65990651&is=65869151&hm=f3bb793f92a3ba6b2b235c2c9cbcf12dd4c6a27513effb859d764c7bee673f4d& 08:50 < bridge> is the console execution queue mt? 08:51 < bridge> i believe so 08:51 < bridge> dont take my word for it 08:51 < bridge> in macos 08:51 < bridge> CXX=/usr/bin/g++-13 would work? 08:51 < bridge> no 08:51 < bridge> Config using it now might explain some of the bizarre new bugs 08:51 < bridge> github macos containers have gcc 13 08:52 < bridge> maybe in the ci it might work 08:52 < bridge> idk what they use 08:52 < bridge> Clang/LLVM 14.0.3 08:52 < bridge> Clang/LLVM (Homebrew) 15.0.7 - available on $(brew --prefix llvm@15)/bin/clang 08:52 < bridge> GCC 11 (Homebrew GCC 11.4.0) - available by gcc-11 alias 08:52 < bridge> GCC 12 (Homebrew GCC 12.3.0) - available by gcc-12 alias 08:52 < bridge> GCC 13 (Homebrew GCC 13.2.0) - available by gcc-13 alias 08:53 < bridge> unrelated q but why is my chat command's pResult->NumArguments() only saying there is 1 arg when in fact there are 2 08:55 < bridge> :ddnet_lgbt: 09:00 < bridge> ```cpp 09:00 < bridge> // execute config file 09:00 < bridge> if(pStorage->FileExists(CONFIG_FILE, IStorage::TYPE_ALL)) 09:00 < bridge> { 09:00 < bridge> pConsole->SetUnknownCommandCallback(SaveUnknownCommandCallback, pClient); 09:00 < bridge> if(!pConsole->ExecuteFile(CONFIG_FILE)) 09:00 < bridge> { 09:00 < bridge> const char *pError = "Failed to load config from '" CONFIG_FILE "'."; 09:00 < bridge> dbg_msg("client", "%s", pError); 09:00 < bridge> pClient->ShowMessageBox("Config File Error", pError); 09:00 < bridge> PerformAllCleanup(); 09:00 < bridge> return -1; 09:00 < bridge> } 09:00 < bridge> pConsole->SetUnknownCommandCallback(IConsole::EmptyUnknownCommandCallback, nullptr); 09:00 < bridge> } 09:00 < bridge> ``` 09:00 < bridge> @learath2 i see this but where is the callback called on execute file? xD 09:01 < bridge> Look for a findcommand somewhere in executeline 09:01 < bridge> i guess it's always reporting as 2 when it's 3 or more 09:01 < bridge> ah 09:01 < bridge> is it not delimiting args by space after the actual name of the command? 09:01 < bridge> do i have to do that myself 09:01 < bridge> What does your arg string look like? 09:02 < bridge> If you have an r it won’t split anymore 09:02 < bridge> but i dont see where a thread is started 09:02 < bridge> an r? 09:02 < bridge> an actual 'r' 09:02 < bridge> When you register a command you give a definition of it’s arguments 09:03 < bridge> Something like “sss” for a command that takes 3 strings e.g. 09:03 < bridge> oic 09:03 < bridge> i didn't realize that actually did anything :smileu 09:03 < bridge> i didn't realize that actually did anything 😃 09:03 < bridge> r means rest, so it’ll give you all the rest of the string at that point 09:04 < bridge> gotcha 09:04 < bridge> we should speak british english 09:04 < bridge> colour 09:05 < bridge> now that i have lot of free time its time to do prs 09:05 < bridge> and redeem myself as a ddnet dev 09:05 < bridge> lol 09:05 < bridge> (if macos doesnt hold me back) 09:05 < bridge> holidays moment 09:05 < bridge> anyone here ever rent a macos vps 09:05 < bridge> i have a m1 myself 09:05 < bridge> oh yeah i forgot 09:05 < bridge> lucky 09:05 < bridge> from work 09:06 < bridge> @learath2 did u check ewan pr 09:06 < bridge> feel free to merge it 09:07 < bridge> do u know what version of clang supports pmr 09:07 < bridge> can CConsole::CResult::GetFloat ever return NaN 09:07 < bridge> 15? 16? 17? 09:07 < bridge> no idea 09:09 < bridge> well with brew u can get llvm 17 09:09 < bridge> so 09:14 < bridge> wanted? 09:14 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1188031898841255976/Base_Profile_2023.12.23_-_01.13.08.03.DVR-24.mp4?ex=65990bed&is=658696ed&hm=bfca3c21e714a65350816a1822e1053c9faf10e6dccc4e70adaf2915fb5e9d36& 09:15 < bridge> i made it so u can /tp x y 09:15 < bridge> /tp 09:15 < bridge> or 09:15 < bridge> /tp playername 09:15 < bridge> or 09:15 < bridge> /tp x y 09:16 < bridge> @learath2 why on gentoo i have gcc 12 09:16 < bridge> and not 13 09:17 < bridge> omg 09:17 < bridge> i have it in eselect 09:17 < bridge> nvm 09:17 < bridge> i will make pr 09:17 < bridge> of what 09:18 < bridge> The thing i just sent 09:18 < bridge> NaN should not be possible 09:18 < bridge> 👍 09:18 < bridge> However you can get, HUGE_VAL on overflow and 0 on underflow 09:19 < bridge> We don’t check or catch either 😄 09:19 < bridge> wow awesome 09:20 < bridge> Oh now that I take a look at it we don’t check for invalid either, so you should get a 0 on things that can’t be converted to float too 🙃 09:20 < bridge> Teeworlds moment 09:20 < bridge> i will parse it myself then 09:20 < bridge> /Users/runner/work/ddnet/ddnet/src/base/math.h:6:10: fatal error: algorithm: No such file or directory 09:20 < bridge> 6 | #include 09:20 < bridge> tf why g++ 13 fails 09:20 < bridge> was planning to prepend with + or - for relative coords anyway so i couldn’t use getfloat 09:21 < bridge> It should handle negatives just fine, no? 09:21 < bridge> not what i mean 09:21 < bridge> 10 = absolute 10 09:21 < bridge> +10 = current pos + 10 09:21 < bridge> -10 = current pos - 10 09:22 < bridge> Aha, yeah can’t do that with float 09:22 < bridge> ya 09:22 < bridge> or i could be more explicit and use tildes like minecraft 09:22 < bridge> but doesn't seem needed 09:22 < bridge> it's just ~ vs +/-0 09:23 < bridge> but uhh actually can you place things at negative coords in a map 😅 i feel like i've seen it before 09:23 < bridge> in which case i would have to use a tilde or smth else 09:23 < bridge> need to know real map boundaries 09:26 < bridge> sounds like what i want is the entity clipping rectangle? 09:27 < bridge> ok i surrender 09:27 < bridge> fck macos 09:27 < bridge> i hate ci driven development 09:28 < bridge> xd 09:34 < bridge> this also means i cant modernize other parts 09:34 < bridge> cuz macos 09:34 < bridge> imagine saying u support c++17 but not rly 09:36 < bridge> yea 09:36 < bridge> i was about to say smth 09:36 < bridge> but it would piss u off 09:36 < bridge> 😬 09:38 < bridge> lol 09:38 < bridge> go for it 09:38 < bridge> Voxel really did rq :(. He was cool. Hope he comes back. Although he did say ddnet wasn't as fun anymore couple of times. 09:40 < bridge> life is not daijoubu 09:40 < bridge> https://tenor.com/view/lovyyn-sad-crying-crying-face-anime-cry-gif-23716177 09:40 < bridge> i love this meme 09:41 < bridge> why do all our artists rq xd 09:41 < bridge> I still can’t believe he left because Ryozuki preached rust. It’s like getting angry at a priest for reading the bible 09:41 < bridge> we already have too few 09:41 < bridge> i dont think its just that 09:41 < bridge> he was frustrated with maps too 09:41 < bridge> he said all new maps were unfun or smth 09:42 < bridge> i guess artists arent as keen to open source art as devs are for free software 09:42 < bridge> we are more selfless 09:42 < bridge> it's just bcs they are paid bad in RL 09:42 < bridge> maybe 09:43 < bridge> as dev u get a new job after 1 sec xD 09:43 < bridge> I think artists want more recognition than programmers tbh 09:43 < bridge> xd 09:43 < bridge> ...anyways 09:43 < bridge> ye programmers stay in the shadows 09:43 < bridge> normal ppl dont know john carmack 09:43 < bridge> well he was not paid to be an artist afaik 09:44 < bridge> true 09:44 < bridge> idk what ravie does 09:44 < bridge> db manager 09:44 < bridge> i mean as job 09:44 < bridge> xd 09:44 < bridge> idk 09:45 < bridge> guys what are the actual map boundaries 09:45 < bridge> He is a professional edgelord. Gets paid to have unwoke opinions 09:45 < bridge> let's say for entities 09:45 < bridge> i just need a number rn to test this 09:45 < bridge> Plays the accordeon 09:45 < bridge> -i16 +i16?? 09:45 < bridge> idk 09:45 < bridge> xd 09:46 < bridge> 09:46 < bridge> where SHORT_MAX macro xd 09:46 < bridge> :feelsbadman: 09:46 < bridge> i just said it randomly idk tbh 09:46 < bridge> I doubt there is any if you remove the death border, you just go out until floats become very inaccurate and bizarre things happen 09:46 < bridge> Teeworlds farlands 09:46 < bridge> k what is the death border 09:46 < bridge> i think its 20 tiles away from the map size 09:46 < bridge> ouu 09:46 < bridge> or smth like that 09:47 < bridge> can maps go negative 09:47 < bridge> on either x or y 09:47 < bridge> basically if it goes to negative after hitting float limit, it wont render theorically 09:47 < bridge> u sometimes dont make sense xd 09:47 < bridge> ig i should ask if maps can exist outside of quadrant 4 09:47 < bridge> It shouldn’t, float overflow works differently 09:47 < bridge> float loses accuracy as it goes further from 0 iirc 09:47 < bridge> so it would just reset 09:47 < bridge> so its not about not being able to render 09:47 < bridge> float overflow is a myth 09:47 < bridge> You’ll get stuck at HUGE_VAL 09:48 < bridge> just use float128 09:48 < bridge> big boi float 09:48 < bridge> is huge val also for negatively huge numbers 09:48 < bridge> so it would just reset (as in if its 64 or 128) hitting limit 09:48 < bridge> tending towards - infinity 09:48 < bridge> HUGE_VAL + d == HUGE_VAL forall d > 0 iirc 09:48 < bridge> https://en.cppreference.com/w/cpp/numeric/math/HUGE_VAL 09:48 < bridge> HUGE_VALF Expands to positive float expression that indicates overflow 09:48 < bridge> HUGE_VAL Expands to positive double expression that indicates overflow, not necessarily representable as a float 09:48 < bridge> HUGE_VALL Expands to positive long double expression that indicates overflow, not necessarily representable as a float or double 09:49 < bridge> i guess i will use placeholders for now. i need to know how to get this info tho 09:50 < bridge> https://doc.rust-lang.org/std/primitive.f64.html#associatedconstant.INFINITY 09:54 < bridge> @learath2 did u know arm uses 16 byte align 09:54 < bridge> macos 09:54 < bridge> I did not know it as fact, but I’d guess it given thumb instructions are 16b 09:55 < bridge> ah wait 09:55 < bridge> its 16 for > 128bit 09:56 < bridge> https://github.com/ziglang/zig/issues/2987 https://github.com/rust-lang/rust/issues/54341 09:56 < bridge> ok wait this is unrelated 09:56 < bridge> xdd 09:56 < bridge> but this shit came up at work 09:56 < bridge> when making the compiler 09:57 < bridge> damn 09:57 < bridge> okay i added relative modes 09:57 < bridge> i still need to know if maps can exist outside quadrant 4 09:57 < bridge> so i can reserve -X.X for non relative purposes 09:57 < bridge> absolute 09:57 < bridge> sdiffjsd 09:58 < bridge> but ye 64bit arm is 16 10:01 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1188043768767709194/Base_Profile_2023.12.23_-_02.01.04.05.DVR-24.mp4?ex=659916fb&is=6586a1fb&hm=40fd73e16f13496ad6a24a213be47c59700c0433d3fa3b718168340375c61428& 10:02 < bridge> tbh it would be easy to just make it ~+ or ~- instead 10:08 < bridge> im going with tildes for now 10:17 < bridge> ur a tilde 10:18 < bridge> wtf 10:18 < bridge> rude 10:44 < bridge> Ngl, but this seems more unpractical to use than current tp 10:45 < bridge> yea i too love zooming in and inching towards the exact tenth place offset i need 10:45 < bridge> ??? 10:45 < bridge> it exists for a different purpose 10:45 < bridge> also can be bound... 10:51 < bridge> The only real application I see tp this it's if I wanted to go far to some direction to save me like 2 secs of dezooming. 10:51 < bridge> Otherwise most of tp needs too much precision for me to somehow guess the exact coordinates 10:52 < bridge> well then i didnt make this for you 10:52 < bridge> i think it would be quite helpful 10:52 < bridge> Talking about tp, something that could really be useful is not falling just after tp (already happens when using it with spec) 10:52 < bridge> how else would it work 10:53 < bridge> i guess it wouldn't be hard to put the player in a limbo state but i dont want to mess with prediction code 10:53 < bridge> ^^ 10:53 < bridge> I was just giving my opinion. I'm sorry to hurt you? Idk. 10:53 < bridge> If you receice some positive feedback I'd like to know the use of it, because I can't really come up with anything other than fast travel to far distances 10:54 < bridge> have you ever played a map and wanted to test a setup on the fly or something 10:54 < bridge> you can iterate on starting coordinates for the setup using this without just tapping a and d until your fingers bleed 10:54 < bridge> Oh, ok I see what you mean 10:55 < bridge> it seems like you don't really play the game because it's really really common for me to be playing with other people & all of the sudden coordinates matter a lot 10:55 < bridge> You want to use it to repeat a setup 10:55 < bridge> or i guess you have a radically different playstyle 10:55 < bridge> Well, I usually just accomplish whatever I try eithouth needing 99999 attempts 10:56 < bridge> Ok I ll stop the beef here, but y I see 11:15 < bridge> i just got trolled hard by vec4 11:15 < bridge> spent about 30 min trying to figure out why i get sent out of bounds & subsequently killed only when my bounds checking is on 11:15 < bridge> `std::clamp(BaseY, Boundaries.y + 32.f, Boundaries.y + Boundaries.h - 32.f)` 11:15 < bridge> and i was doing it like that 11:15 < bridge> but .h is the same as .x.... it's h for HSL 11:16 < bridge> i needed .l (length) 11:16 < bridge> TBH we could likely remove the color aliases at some point since we use `ColorRGBA` in most places 11:17 < bridge> nice 11:21 < bridge> i have sort of a niche need atm robyt 11:21 < bridge> i am bounds checking /tp coordinates from my video up there but this requires getting the game layer & saving its boundaries 11:22 < bridge> i don't want to do it every frame but making it static would not be good because it would persist after a map change if it's only set once 11:22 < bridge> should i check if the map changed inline or make it a member of CGameContext, and make it stick out like a sore thumb 11:23 < bridge> i don't want to do it every time the command is called but making it static would not be good because it would persist after a map change if it's only set once 11:26 < bridge> Doesn't seem very expensive to calculate the boundaries. Do you mean something like `width+201`? 11:26 < bridge> yea 11:27 < bridge> i suppose i will just do it every frame 😃 11:27 < bridge> `CCollision` keeps track of the game layer size, so if you wanted a cache then that would be the place, but just for `width+201` it's not really worth it 11:27 < bridge> I'd say profile first if it's an issue, otherwise it's premature optimization 11:27 < bridge> k 11:27 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1188065461758337074/image.png?ex=65992b2f&is=6586b62f&hm=4b2d0adb82a554d8a844e9ab56125af04c737f5257cfadf444b67e47012e8155& 11:28 < bridge> this is all it is 11:28 < bridge> i think it should be fine 11:30 < bridge> @mpft u can finally get dev role 11:30 < bridge> nope 11:30 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1188066063536103484/image.png?ex=65992bbe&is=6586b6be&hm=1a680ae3094fe4bf48b85a2eed3924e98282848ec7967cc8d750372bb808e0fa& 11:30 < bridge> trolled again! 11:30 < bridge> xd 11:30 < bridge> these are issues from 2020 11:30 < bridge> all of them complaints from heinrich 11:30 < bridge> heinrich singlehandedly stopping progress. nice 11:31 < bridge> And somehow we have two issues about the same thing 11:31 < bridge> i really have not heard anyone but heinrich complain about that approach 11:32 < bridge> If it generates lots of server messages then it's bad for the servers 11:32 < bridge> The comment in #2221 explain a case in one map where it happens 11:32 < bridge> https://github.com/ddnet/ddnet/pull/2221 11:36 < bridge> what exactly is the issue rn? 11:36 < bridge> can u eli5 11:36 < bridge> kill will act like /r right? 11:36 < bridge> 11:36 < bridge> /r only works if u stand still somewhere, right? 11:37 < bridge> yes exactly 11:37 < bridge> then i dont see a problem with your design 11:37 < bridge> the only place that you can get softlocked or repeatedly teleported without interfering has been removed in my pr 11:37 < bridge> If you stand on a speeder and it moves you into a kill tile 11:37 < bridge> then speeders shouldn't be safe 11:37 < bridge> I only skimmed the comments 11:37 < bridge> but /r only works if u stand still 11:37 < bridge> so this cant even happen 11:38 < bridge> Then the comments still need to be "addressed" by extensive testing and explanation that this cannot happen 11:38 < bridge> if not, then i'd claim that /r is bugged 11:38 < bridge> yeah, the approach that heinrich wants is pretty overcomplicated tho. 11:38 < bridge> 11:39 < bridge> better try to make it easier by restricting it to our case 11:39 < bridge> хуй член 11:39 < bridge> It could be possible to have a velocity of `vec(0, 0)` temporarily while inside a speeder 11:39 < bridge> 🐡 11:39 < bridge> well then stand still and dont press any key 11:40 < bridge> for 2 ticks 11:40 < bridge> xdd 11:41 < bridge> but pressing /r after died 11:41 < bridge> or not dieing, when you expect it defs sounds more unintuitive 11:42 < bridge> @mpft Can you some of the unrelated style changes in your PR? Looks like you used clang-format-15 instead of 10 11:42 < bridge> @mpft Can you avoid some of the unrelated style changes in your PR? Looks like you used clang-format-15 instead of 10 11:42 < bridge> it’s literally just like gravity 11:42 < bridge> i’d like to but idk how to set it up with my ide 11:42 < bridge> i will have to manually apply style changes inplace with the cli otherwise 11:43 < bridge> You could simply not stage, commit and push those changes :owo: 11:43 < bridge> err we must not be talking about the same thing 11:43 < bridge> anyway why does ddnet not use 15 11:43 < bridge> quite annoying 11:43 < bridge> Because the format looks trash 11:43 < bridge> https://github.com/ddnet/ddnet/pull/7696/files#diff-29ffe32916052e1066eed938021aadfeb29f855d7c63d9c1ca3350aceffb79f3L1246-R1247 11:43 < bridge> can’t you specify further 11:43 < bridge> maybe we could invest some day in a definition about which tiles actively affect gameplay. 11:43 < bridge> 11:43 < bridge> would be intersting, e.g.: 11:43 < bridge> - air tiles 11:44 < bridge> - tele out 11:44 < bridge> - tune zones 11:44 < bridge> 11:44 < bridge> are all passive 11:44 < bridge> Interfacing with clang-format is black magic 11:44 < bridge> it’s literally just a file 11:44 < bridge> and you write the rules you want 11:44 < bridge> ez as pie 11:44 < bridge> But I wish someone would do it of course 11:44 < bridge> just ping deen, he fixes clang-format for you 11:44 < bridge> He also didn't know how to get lines not to break 11:45 < bridge> well sorry if you don’t agree but subjecting every contributor to use an old version of clang format when they do any more than 3 line changes doesn’t exactly seem logical 11:45 < bridge> Ideally clang-format would either preserve our line lengths or at least not do something as stupid as the format I linked above 11:45 < bridge> you can give it an explicit max line width 11:46 < bridge> @mpft u can take over #7034 11:46 < bridge> https://github.com/ddnet/ddnet/pull/7034 11:46 < bridge> ehh 11:46 < bridge> The version and format should be upgrades yeah, but contributions shouldn't contain unrelated changes either 11:47 < bridge>