08:10 < bridge> war is no more, we landed fixes for russia and ukraine 08:10 < bridge> :justatest: 08:10 < bridge> >_> 08:44 < bridge> bruh 11:44 < bridge> ima fix https://github.com/ddnet/ddnet/issues/6638 11:45 < bridge> @Ryozuki could you change the representation in the server to `std::optional` everywhere? 11:45 < bridge> so we don't have the magic value -9999 there 11:45 < bridge> context? 11:46 < bridge> isnt more -9999 a magic value that has to be sent due to the client interpreting it specially 11:46 < bridge> i see it in the server info in the browser sometimes 11:46 < bridge> but yeah you can’t send a std optional over net lol 11:47 < bridge> I'm guessing heinrich is saying it should be optional everywhere within the server and only get serialized as -9999 11:47 < bridge> yeah 11:47 < bridge> which is half that way already 11:50 < bridge> ah i see 11:52 < bridge> yup, but the score is somehow -9999 and that has to be interpreted by the 0.7 code to be changed to -1, I think 11:52 < bridge> why is any negative score value possible 11:52 < bridge> time or real score 11:52 < bridge> just de/serialize as unsigned 11:52 < bridge> i think the cclient in serverbrowser.h needs to stay non optional 11:54 < bridge> I only meant in the server; but theoretically, even the serverbrowser.h could be made `std::optional` 11:55 < bridge> true 12:23 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1110150923608653914/image.png 12:23 < bridge> fixed it, but sometimes there is 1 player showing without time at the top 12:23 < bridge> rly weird 12:24 < bridge> his time is 6:43 12:24 < bridge> in game 12:32 < bridge> -3223 12:32 < bridge> why does this guy report a negative score 12:33 < bridge> is this some kind of bug? 12:33 < bridge> idk i see them too 12:33 < bridge> oh 12:33 < bridge> the current client displays them as having no time 12:33 < bridge> but he has 53 mins 12:34 < bridge> in game 12:34 < bridge> damn 12:39 < bridge> well the score is either full negative to 0 being time 0 12:39 < bridge> or positive to 0 12:39 < bridge> so abs fixes it 12:41 < bridge> client-side? could you only do the `abs` if the server doesn't specify that it's doing time scores? 12:42 < bridge> the thing is 12:42 < bridge> ddnet is reporting time score 12:42 < bridge> and some clients send a negative score for some reason 12:42 < bridge> 1-3 usually 12:42 < bridge> idk why 12:42 < bridge> clients? 12:42 < bridge> game servers? 12:42 < bridge> im looking at where ddnet sends the server info 12:42 < bridge> the ddnet client, reports a player having a negative score 12:42 < bridge> like -3305 12:42 < bridge> whne it should be positive 12:43 < bridge> because ddnet reports time score 12:43 < bridge> (oficial server) 12:43 < bridge> hmmm 12:43 < bridge> that's weird 12:43 < bridge> the current client 16.9 doesnt even show them having time 12:43 < bridge> due to this 12:43 < bridge> but u see them with time when u join 12:43 < bridge> and look tab 12:44 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1110156120410030191/image.png 12:44 < bridge> i have this on the sort rn 12:44 < bridge> and it displays all good 12:44 <+ChillerDragon> ircd u heinrich 12:44 < bridge> i had to change the render of the score too in the browser 12:44 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1110156230565036082/image.png 12:44 < bridge> (but we shouldn't add compatibility with buggy servers if we can just fix the buggy servers) 12:44 < bridge> this is to render the negative score players on time too 12:44 < bridge> true 12:44 < bridge> altho this fix is harmless 12:44 < bridge> im trying to find where ddnet sends the info 12:45 < bridge> src/engine/server/server.cpp 12:45 < bridge> `CServer::UpdateRegisterServerInfo` 12:45 < bridge> `m_aClients[i].m_Score == -1 ? -9999 : m_aClients[i].m_Score` 12:45 < bridge> its this currently 12:46 < bridge> added by u 12:46 < bridge> i guess here its a good place 12:46 < bridge> to use the optional 12:46 < bridge> i guess i forgot to chang eit 12:47 < bridge> yea 12:47 < bridge> note that this supports setting the time to 9999, even 12:47 < bridge> true 12:47 < bridge> but its not backcompat 12:47 < bridge> to old clients 12:47 < bridge> or is it 12:48 < bridge> i dont care but i know u care 12:48 < bridge> I think for this particular thing, I don't care so much 12:48 < bridge> but let me check anyway 12:48 < bridge> (because it's not a problem when trying to play the game) 12:49 < bridge> what score do we send to sixup 12:49 < bridge> when no score is there 12:49 < bridge> I checked it when doing my PR, you can look there 12:49 < bridge> -1, I think 13:11 < bridge> > The absolute(CurrentClient.m_Score) >= 0 seems pointless. If it's supposed to check for MIN_INT, then the call to absolute is already UB. 13:11 < bridge> no 13:11 < bridge> it is meant to check for the negative values ddnet sends sometimes 13:13 < bridge> the int min is used on a temp var to stort 13:13 < bridge> sort, its never there 13:14 < bridge> absolute converts a number into a non-negative number 13:14 < bridge> yeah 13:14 < bridge> so checking whether the absolute is greater or equal to zero sounds pointless 13:14 < bridge> ah true 13:14 < bridge> xd 13:17 < bridge> well i dont have the will to figure out why the sv sends negative sometimes 13:17 < bridge> so u can accept the fix or wait a undetermined amount of time 13:33 < bridge> Isn’t it supposed to be negative for times? 13:35 < bridge> it doesnt matter 13:35 < bridge> the client always did abs on the score 13:35 < bridge> time and score handling sucks 13:36 < bridge> cuz back compat 13:36 < bridge> i hate back compat 13:36 < bridge> and i shouldnt have gotten into this 13:36 < bridge> i regret itn ow xd 13:39 < bridge> idk why ddnet-libs got updated 13:39 < bridge> and how to revert it 13:39 < bridge> today is not my day oof 13:41 < bridge> Reset mixed, cd into submodule, reset hard, cd back out, commit, force push 13:43 < bridge> reset mixed? 13:43 < bridge> how 13:44 < bridge> Well first, is it the last commit or another commit you updated submodule in? 13:44 < bridge> idk 13:44 < bridge> warning: --mixed with paths is deprecated; use 'git reset -- ' instead. 13:45 < bridge> ❯ git reset --mixed upstream/master -- ddnet-libs/ 13:45 < bridge> warning: --mixed with paths is deprecated; use 'git reset -- ' instead. 13:45 < bridge> Unstaged changes after reset: 13:45 < bridge> M ddnet-libs 13:45 < bridge> It seems to be the very first commit 13:45 < bridge> i did this 13:45 < bridge> Do you want to squash your commits? 13:45 < bridge> my inner self doesnt want to, cuz commit points xd 13:45 < bridge> but i dont mind 13:46 < bridge> Δ ddnet-libs 13:46 < bridge> ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────� 13:46 < bridge> 328fd20..625457e 13:46 < bridge> Ok, `git reset —hard origin/pr_fix_info; git rebase -i upstream/master` 13:46 < bridge> In the interactive rebase mark the very first commit with `e` instead of `pick` 13:47 < bridge> ah ye 13:47 < bridge> i fixup'ed the others 13:47 < bridge> felt guilty 13:48 < bridge> Rebase will check out your first commit, when there cd into the submodule, `git reset —hard HEAD`, get out, `git commit —amend`, `git rebase —continue` and a force push to finish it up 13:48 < bridge> ❯ git reset --hard HEAD 13:48 < bridge> HEAD is now at 625457e Update libraries 13:48 < bridge> i think thats the wrong commit 13:49 < bridge> oh 13:49 < bridge> i just needed to git pull 13:49 < bridge> XD 13:49 < bridge> ❯ git pull 13:49 < bridge> Updating 625457e..328fd20 13:49 < bridge> Fast-forward 13:50 < bridge> got it 13:50 < bridge> Nope 13:50 < bridge> Still managed to update ddnet-libs 😄 13:51 < bridge> nah 13:51 < bridge> refresh 13:52 < bridge> ill remove the useles math header too 13:52 < bridge> You made 2 commits, one changing ddnet-libs, the next reverting it 13:52 < bridge> lol true 13:52 < bridge> xd 13:52 < bridge> With the exact same name 13:53 < bridge> Git struggles 13:53 < bridge> now 13:54 < bridge> i tested it a bit, and it works nice 13:54 < bridge> Congrats 13:54 < bridge> points are shown in order, time in ordere 13:54 < bridge> idk if i did test any backcompat time server 13:54 < bridge> cuz idk which one is 13:54 < bridge> well 13:55 < bridge> fokko one is 13:55 < bridge> maybe 13:55 < bridge> Unique probably isn’t all the way up to date 13:56 < bridge> @Learath2 do u know 13:56 < bridge> if gores reports some time 13:56 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1110174347429158922/image.png 13:56 < bridge> Hm, KoG has been trying to follow closer to master, but idk if they got the time flag yet 13:57 < bridge> But judging by your screenshot backcompat does look broken 13:57 < bridge> @Avolicious update kog, make it send "score_kind": "time" to masters ty bye 13:57 < bridge> idk if its set to backcompat 13:57 < bridge> or points here 13:57 < bridge> Always the easy way out with you people 😄 13:58 < bridge> xd 13:58 < bridge> I have electromagnetism to go study. This isn’t in the RC yet is it? 13:58 < bridge> If it is the RC is not shippable imo 13:59 < bridge> wdym 14:00 < bridge> @Learath2 im making him a favour 14:00 < bridge> btw 14:00 < bridge> 16.9 14:00 < bridge> shows same 14:00 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1110175300345671780/image.png 14:00 < bridge> so its not that its not backcompat 14:00 < bridge> its thatis interpreted as points 14:00 < bridge> Mh, then 16.9 shouldn’t have been shipped, meh 14:00 < bridge> u mean all versions? 14:00 < bridge> since kog changed ddnet to kog 14:01 < bridge> has been like this iirc 14:01 < bridge> when u join it shows time tho 14:01 < bridge> the proper fix here is for them to send a score_kind 14:01 < bridge> and not us to add a special gores check 14:01 < bridge> A negative score and a raceish~ gametype should always result in time score displayed 14:01 < bridge> KoG is latest ddnet lol 14:01 < bridge> not latest enough 14:01 < bridge> Its latest latest 14:02 < bridge> update to current master 14:02 < bridge> its current master 14:02 < bridge> is that server updated 14:02 < bridge> or have you pushed in the last 10 minutes? 14:02 < bridge> do u send score_kind 14:02 < bridge> y 14:02 < bridge> 7 months ago 14:02 < bridge> Then it’s worse than the backcompat being broken 14:02 < bridge> @Avolicious ah 14:03 < bridge> its "client_score_kind" 14:03 < bridge> first KoG server that I check doesn't send it 14:03 < bridge> `"client_score_kind": "time"` 14:03 < bridge> `"tw-0.6+udp://5.181.124.84:8303"` 14:03 < bridge> u assume the worst of us 14:03 < bridge> and not others 14:03 < bridge> smth 14:03 < bridge> in: `https://master1.ddnet.org/ddnet/15/servers.json` 14:04 < bridge> backcompat is only set on these 14:04 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1110176314721308732/image.png 14:04 < bridge> race and fastcap 14:04 < bridge> so we not forcefully setting gores to backcompat 14:04 < bridge> they should send the proper flag 14:05 < bridge> Ah I remember they changed gametypes, it’s Gores now 14:05 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1110176545005383722/Screenshot_2023-05-22_140502.png 14:05 < bridge> Maybe for some reason that codepath isn’t being taken? Or the server just hasn’t been updated due to a silent deployment issue? 14:06 < bridge> Though looks pretty hardcoded to me 14:06 < bridge> can you confirm that `"tw-0.6+udp://5.181.124.84:8303"` is on your latest master? @Avolicious 14:06 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1110176860941324369/image.png 14:06 < bridge> u not sending it 14:07 < bridge> Yes, are the latest stable ones 14:07 < bridge> @heinrich5991 could the master filter it out? 14:07 < bridge> it should reflect all u send right 14:07 < bridge> odd 14:07 < bridge> the master doesn't look at the JSON 14:07 < bridge> yeah 14:07 < bridge> why is it not there 14:07 < bridge> to me, it looks like that particular server doesn't send it 14:08 < bridge> which would mean that the server is likely not runnign the code that Avo thinks it's running 14:08 < bridge> none do 14:08 < bridge> havne't checked the others 14:08 < bridge> but Ryo did, probably 🙂 14:08 < bridge> `UpdateRegisterServerInfo` is where the flag gets set 14:08 < bridge> I've not changed anything on HTTPs Register stuff 14:10 < bridge> but are u sure the deployed servers are using the version u expect 14:10 < bridge> If you didn’t change anything there then I’m also voting some deployment issue 14:10 < bridge> Servers do have this version 14:10 < bridge> We verify it by comparing the SHA256 File hash 14:10 < bridge> And Git commit hash is also deployed in the container image 14:10 < bridge> Okay, then it’s divine intervention 14:11 < bridge> not having the source, we can't trace it as easily 14:11 < bridge> actually, unlikely to be a source issue 14:11 < bridge> but likely deployment 14:11 < bridge> oh i forgot its closed source 14:12 < bridge> can't help a lost cause 14:12 < bridge> (im joking pls no ban) 14:16 < bridge> @Learath2 i ruined my kimetsu episode watch 14:17 < bridge> smh 14:17 < bridge> Because of timescores? 14:17 < bridge> ye 14:17 < bridge> stopped mid ep 14:17 < bridge> and now i have a meeting 14:17 < bridge> xdxd 14:17 < bridge> Oof 14:17 < bridge> i like to watch anime while i eat 14:26 < bridge> @Avolicious and I figured it out, the `client_score_kind` change was merged just after the last KoG release 14:28 < bridge> xD 14:42 < bridge> @heinrich5991 i think the abs should stay imho, we dont have a set standard on how to report the time, so maybe some server says kind: time and sends it negative 14:42 < bridge> the absolute works always 14:43 < bridge> i dont say we shouldnt fix the bug 14:43 < bridge> do u know if the http server info the server sends uses the info from the packer? 14:43 < bridge> `ADD_INT(q, !m_aClients[i].m_Score.has_value() ? -9999 : m_aClients[i].m_Score.value() == 9999 ? -10000 : -m_aClients[i].m_Score.value()); // client score` 14:43 < bridge> this is what we have on the packer 14:43 < bridge> well on the ptr i changed it to use a optional 14:45 < bridge> on the http i changed it to 14:45 < bridge> `m_aClients[i].m_Score.value_or(-9999)` 14:45 < bridge> but maybe i can abs the value there? but we wouldnt be getting to the root of the problem 14:45 < bridge> where the score is set to negative somwhere 14:46 < bridge> I think we should not do the abs in order to establish a standard 14:46 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1110186963186765834/image.png 14:46 < bridge> there is this 14:47 < bridge> it does not 14:48 < bridge> we could probably just pass on the option in that code snippet 14:48 < bridge> in this one 14:48 < bridge> ok 14:49 < bridge> @heinrich5991 can i compare a std::optional 14:49 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1110187721042964480/image.png 14:49 < bridge> for the expire 14:49 < bridge> can i simply so m_Score != Score 14:49 < bridge> xd 14:49 < bridge> do* 14:50 < bridge> in rust u can 14:50 < bridge> https://en.cppreference.com/w/cpp/utility/optional/operator_cmp 14:50 < bridge> seems so 14:50 < bridge> ok seems like its a sane optional 14:50 < bridge> the only thing it lacks is map 14:51 < bridge> `transform` 14:51 < bridge> C++23 though 14:51 < bridge> C++ finally catching up on basic functionality 14:52 < bridge> 😂😂 14:52 < bridge> Let's skip cpp20 14:53 < bridge> @heinrich5991 do u wanna break the compat then 14:54 < bridge> and allow 9999 time 14:54 < bridge> - we fix the bug 14:54 < bridge> - negative numbers mean no time 14:54 < bridge> - 0 and 9999 are valid times 14:55 < bridge> u know 14:55 < bridge> actuall 14:55 < bridge> ywe should drop score altogether for ddnet 14:55 < bridge> and show a proper time 14:55 < bridge> with more resolution even 14:56 < bridge> so instead of seconds 14:56 < bridge> we send miliseconds 14:59 < bridge> I'd rather not, probably 14:59 < bridge> we can already do this for the serverbrowser, just not ingame, I think 15:00 < bridge> ill just leave this comment 15:00 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1110190433151238175/image.png 15:00 < bridge> in the in game time reporting 15:01 < bridge> this code is like this already btw 15:01 < bridge> im trying to find where its negative xd 15:02 < bridge> the `absolute` should probably be removed there 15:02 < bridge> oh 15:02 < bridge> maybe its set to negative if someone finished a map 15:02 < bridge> https://cdn.discordapp.com/attachments/293493549758939136/1110191037097455656/image.png 15:02 < bridge> due to this 15:03 < bridge> this is on the onfinish 15:03 < bridge> I'd say: remove all the `absolute`s and think about whether we want negative or positive numbers, probably positive ones 15:03 < bridge> but that abs is on the ingame code 15:03 < bridge> not serverbrowser 15:03 < bridge> but yeah 15:03 < bridge> ill remove it 15:04 < bridge> it's inside the server, right? 15:04 < bridge> (the server is the creator of that value, it knows whether it's positive or negative) 15:04 < bridge> yeah 15:04 < bridge> im gonna remove it all and make sure its positive 15:04 < bridge> i think the source of the negative is the onfinish thing 15:05 < bridge> btw 15:05 < bridge> ah 15:05 < bridge> that makes sense 15:05 < bridge> @heinrich5991 whats better `-1 * m_Score.value()` or `-m_Score.value()` 15:05 < bridge> the latter IMO 15:07 < bridge> @heinrich5991 is it safe 15:07 < bridge> `m_Score = Result.m_Data.m_Info.m_Time;` 15:07 < bridge> where 15:07 < bridge> m_score is option 15:07 < bridge> m_time is option 15:07 < bridge> ? 15:07 < bridge> ```cpp 15:07 < bridge> public: template<> 15:07 < bridge> enable_if_t<__and_v<__not_>, is_constructible, is_assignable, __not_<__converts_from_optional>, __not_<__assigns_from_optional>>, std::optional &> operator=(const optional &__u) noexcept(__and_v, is_nothrow_assignable>) 15:08 < bridge> ``` 15:08 < bridge> i guess yes? xd 15:08 < bridge> oof 15:08 < bridge> let me check 😄 15:08 < bridge> (I'm not actually a C++ wizard) 15:08 < bridge> xD 15:09 < bridge> https://en.cppreference.com/w/cpp/utility/optional/optional 15:09 < bridge> 4 15:09 < bridge> seems like that's the `map` you've been looking for 😄 15:09 < bridge> lmao 15:09 < bridge> although very constrained 15:10 < bridge> > (conditionally explicit) 15:10 < bridge> not sure if I want to find out what that means 15:10 < bridge> well then 15:10 < bridge> ill fix this to be positive 15:10 < bridge> maybe i need to change again the sort on the info 15:10 < bridge> and this may mean partially broken until servers update 15:10 < bridge> and clients 15:10 < bridge> or idk 15:11 < bridge> sounds good 🙂 15:11 < bridge> @heinrich5991 how to make my sv register to a local master 15:11 < bridge> ill need this to test later 15:11 < bridge> `sv_register_url` 15:12 < bridge> set it to `sv_register_url http://127.0.0.1:1234/ddnet/15/register` 15:12 < bridge> and `http_allow_insecure 1` 15:13 < bridge> set it to `sv_register_url http://[::1]:8080/ddnet/15/register` 15:59 < bridge> i forgot 15:59 < bridge> where do i add a master to the client xd 16:00 < bridge> ~/.ddnet/ddnet-master-urls.cfg 16:01 < bridge> i dont have .ddnet 16:01 < bridge> i have .local/share/ddnet 16:01 < bridge> i dont see that file 16:02 < bridge> `ddnet-serverlist-urls.cfg` 16:02 < bridge> probably doesn't exist by default 16:02 < bridge> whats the format? 16:02 < bridge> put an URL into that file 16:02 < bridge> http://[::1]:8080 16:02 < bridge>