01:11 <+bridge> [ddnet] Is this better? 01:11 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/1017572957599571968/unknown.png 01:11 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/1017572957838639175/unknown.png 01:15 <+bridge> [ddnet] And about this, it's decided that feet should only flip in AFK state? 01:15 <+bridge> [ddnet] And about this, it's decided that feet should only flip in AFK state for now? 01:52 <+bridge> [ddnet] @Voxel now it just looks like this 01:52 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/1017583326736957570/unknown.png 01:53 <+bridge> [ddnet] its the people's say :justatest: 01:53 <+bridge> [ddnet] but the weapon is leaning on his head, that can't be comfortable 01:58 <+bridge> [ddnet] How about weapon on the side, in his front? 02:00 <+bridge> [ddnet] you mean like this? 02:00 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/1017585302535159868/unknown.png 02:01 <+bridge> [ddnet] it should just be pointing where his eyes are like normal 02:02 <+bridge> [ddnet] So no weapon alteration? 02:03 <+bridge> [ddnet] I guess 02:03 <+bridge> [ddnet] hammer position is nice but default might work as well 02:03 <+bridge> [ddnet] I'll wait until the other people comment as well 02:03 <+bridge> [ddnet] Default is too high. If we do default I'd have to at least lower it 02:03 <+bridge> [ddnet] ye maybe 02:29 <+bridge> [ddnet] The way I see it, the weapon is strapped to the tee's back as they rest, not just freely leaning on them 02:30 <+bridge> [ddnet] I meant flat on the ground next to the tee, but rendered in front of the tee 02:31 <+bridge> [ddnet] you mean stuck magnetically? or maybe by static charge 02:32 <+bridge> [ddnet] :happy: Sure, it's a video game. Why not 02:33 <+bridge> [ddnet] If the weapon is rendered in front, it would cover the feet, making it kind of pointless, no? 02:34 <+bridge> [ddnet] it could also be placed in a way that looks like the tee could possibly be holding it in a hand 02:40 <+bridge> [ddnet] i thought that was the point 02:41 <+bridge> [ddnet] like hes restinf on his weapon 02:41 <+bridge> [ddnet] or yeah like strapped to their back 02:42 <+bridge> [ddnet] Having the weapon strapped to the tee's back is cute, looks fine as well 02:43 <+bridge> [ddnet] Velcro :greenthing: 03:56 <+bridge> [ddnet] Tees have a kangaroo pouch on their backs 07:26 <+bridge> [ddnet] yea, but can you make the weapon render fully normal again (just for a screenshot? 07:43 <+bridge> [ddnet] Oh wait, right. One second 07:47 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/1017672479071813672/unknown.png 07:52 <+bridge> [ddnet] Ravie did give an idea about there being a binded sit animation, where if you press a button you will be able to sit even if not AFK. But that would involve another packet in the server 07:56 <+bridge> [ddnet] That wouldnt be a problem tho, since the sitting animation is only working for new clients anyways, we could easily add such packet 07:56 <+bridge> [ddnet] and such information to send to the clients. Voxel, hit me up I can helo you 07:57 <+bridge> [ddnet] Want me to submit the PR as it is now, with the weapons as is? 07:57 <+bridge> [ddnet] I think we should maybe keep the weapons normal btw. That would then also fit better to manual sitting 07:58 <+bridge> [ddnet] Alrighty 07:58 <+bridge> [ddnet] Probably put it into one PR, as the info for sitting animation would then no longer require the afk info. 07:58 <+bridge> [ddnet] Then its polished from the beginning 07:58 <+bridge> [ddnet] Ah cool. 07:59 <+bridge> [ddnet] So I did talk about this, and I think the best key to bind sitting would be **S** 07:59 <+bridge> [ddnet] at least for default 08:01 <+bridge> [ddnet] Maybe, but s is taken for hookline 08:01 <+bridge> [ddnet] maybe c 08:01 <+bridge> [ddnet] at least for default :D 08:02 <+bridge> [ddnet] Yeah, sure 08:02 <+bridge> [ddnet] i'll check whether c is free 08:02 <+bridge> [ddnet] It says here what binds are default 08:02 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/1017676411630276628/unknown.png 08:02 <+bridge> [ddnet] unsure if these are all of them 08:03 <+bridge> [ddnet] these are all, was gonna check binds.cpp aswell :D 08:03 <+bridge> [ddnet] s isn't shown as hookline though 08:03 <+bridge> [ddnet] SetDDRaceBinds() 08:03 <+bridge> [ddnet] check that function 08:03 <+bridge> [ddnet] fuck, C is used by a useless command 08:04 <+bridge> [ddnet] ohhh 08:04 <+bridge> [ddnet] Wow, so many useless binds 08:04 <+bridge> [ddnet] im happy i dont use them 08:04 <+bridge> [ddnet] same 08:05 <+bridge> [ddnet] i have my own config file, and the first line says `unbindall` 08:05 <+bridge> [ddnet] xD 08:05 <+bridge> [ddnet] xd 08:05 <+bridge> [ddnet] Which key would you suggest now toh 08:05 <+bridge> [ddnet] lemme think 08:05 <+bridge> [ddnet] Z is my "lagg!!!" say bind 08:06 <+bridge> [ddnet] just for a default, but Z is my team chat (y for qwerty) 08:06 <+bridge> [ddnet] you probably mean my Y then right? xD 08:06 <+bridge> [ddnet] yknwo what why not change c bind to n, 08:06 <+bridge> [ddnet] the bottom left 08:06 <+bridge> [ddnet] true 08:06 <+bridge> [ddnet] c fits for crouch 08:06 <+bridge> [ddnet] xd 08:07 <+bridge> [ddnet] yea, and even if N and M are my deepfly binds, i think there's a solo button bind somewhere 08:07 <+bridge> [ddnet] its just for the default, you can set ur bind however u want 08:10 <+bridge> [ddnet] @Voxel have you ever changed code on the server side? Do you want to do this or should I make a commit in your branch, same as for the DDNetLaser? 08:11 <+bridge> [ddnet] Can I try looking at it first? I think it should be rather straight forward and sort of similar to how +fire is treated 08:11 <+bridge> [ddnet] of course I am here for quetions 08:12 <+bridge> [ddnet] sure, but +fire or +showhookcoll are handled quite a bit differently 08:14 <+bridge> [ddnet] I am thinking right now, I think we should implement the `sit` (or similar?) command with an optional parameter 0 or 1, to allow using 0 or 1 for binds. If nothing is entered (as for the default bind), it would simply toggle, I think. 08:15 <+bridge> [ddnet] right\ 08:28 <+bridge> [ddnet] @fokkonaut Is this a good start? 08:28 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/1017682906551963648/unknown.png 08:28 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/1017682906849738812/unknown.png 08:29 <+bridge> [ddnet] You may not edit exisitng NetObjects, as they change network code. This one specifically is even a vanilla object. 08:30 <+bridge> [ddnet] welcome to backwards compatibility 08:30 <+bridge> [ddnet] DDNet has a system (hey heinrich c:) that extends the normal NetObject system. You have to create a NetObjectEx and give it a paramter m_Sit 08:30 <+bridge> [ddnet] alright ill try thaaaat 08:31 <+bridge> [ddnet] @Voxel Look at `MyOwnObject` 08:32 <+bridge> [ddnet] ah, sorry 08:32 <+bridge> [ddnet] @Voxel NetObjects are only used by the server, they are a snapshot object. Dont use that to communicate client->server 08:32 <+bridge> [ddnet] instead, see `Cl_ShowOthers`, its a NetMessageEx 08:34 <+bridge> [ddnet] ah nivr 08:34 <+bridge> [ddnet] ah nice 08:34 <+bridge> [ddnet] tho what does it mean by `# Can't add any NetMessages here!`? Can you not add it below that comment? 08:35 <+bridge> [ddnet] Yes, you can, because you add a `NetMessageEx`. That is only meant for the normal `NetMessage`s, as they are limited. You can't have infinite of them. Thats why this extended system was heavily required and is the foundation of what we can do right now. (heinrich!! c:) 08:36 <+bridge> [ddnet] <3 08:38 <+bridge> [ddnet] While you are working in network.py right now, you might wanna add a flag to `CharacterFlags`, called `IS_SITTING` or similar 08:38 <+bridge> [ddnet] That way we will tell the clients which client is sitting right now 08:39 <+bridge> [ddnet] Alrighty 08:44 <+bridge> [ddnet] okay i think network.py is all set 08:44 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/1017687028135112774/unknown.png 08:44 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/1017687028869124136/unknown.png 08:46 <+bridge> [ddnet] Looks good, yes 08:52 <+bridge> [ddnet] So now I add `bool m_IsSitting;` into CCharacterCore 08:52 <+bridge> [ddnet] and then `if(m_Core.m_LiveFrozen) 08:53 <+bridge> [ddnet] pDDNetCharacter->m_Flags |= CHARACTERFLAG_MOVEMENTS_DISABLED;` 08:53 <+bridge> [ddnet] wait 08:53 <+bridge> [ddnet] So now I add `bool m_IsSitting;` into CCharacterCore 08:53 <+bridge> [ddnet] and then 08:53 <+bridge> [ddnet] `if(m_Core.m_IsSitting) 08:53 <+bridge> [ddnet] pDDNetCharacter->m_Flags |= CHARACTERFLAG_IS_SITTING;` in character.cpp? 08:55 <+bridge> [ddnet] wait nvm those relate to entities i think 08:56 <+bridge> [ddnet] You can add it to `CCharacter` 08:56 <+bridge> [ddnet] The core does not need this information 08:56 <+bridge> [ddnet] Other than that, it was correct, yes 09:02 <+bridge> [ddnet] @Voxel make sure to reset m_IsSitting in `CCharacter::DDRaceInit()` 09:03 <+bridge> [ddnet] to false* 09:07 <+bridge> [ddnet] Actually wait, would it be better inside `void CCharacter::SnapCharacter(int SnappingClient, int ID)` 09:07 <+bridge> [ddnet] What do you mean? 09:07 <+bridge> [ddnet] i don't know, i see a new similar 09:07 <+bridge> [ddnet] one second my brain shut off 09:08 <+bridge> [ddnet] im jjust saying like, since all the m_Flag things are linked to m_Core wouldnt it be weird for one to NOT be m_Core 09:08 <+bridge> [ddnet] You should store m_IsSitting in CCharacter, because you are going to modify that variable when the net message arrives. 09:09 <+bridge> [ddnet] They are not, it's just that the CCharacterCore is shared code, and if things like m_Super are required in the core, it is defined there 09:09 <+bridge> [ddnet] gamecore.cpp is used by the server and the client 09:09 <+bridge> [ddnet] But this information is not required there 09:14 <+bridge> [ddnet] okay i broke it off a tiny bit so it's visually better to understand 09:14 <+bridge> [ddnet] (i havent compiled it yet so thats why the IS_SITTING thing isnt blue yet 09:14 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/1017694349733134336/unknown.png 09:14 <+bridge> [ddnet] or should i not have that extra paragraph 09:15 <+bridge> [ddnet] You can simply remove the line, it's not required :) 09:15 <+bridge> [ddnet] It's not blue yet because it's not yet generated. Things added to the .py files will generate the matching code once you generate or build 09:15 <+bridge> [ddnet] Yeah I know rthat 09:15 <+bridge> [ddnet] Yeah I know that 09:15 <+bridge> [ddnet] okayyy i removed the line 09:15 <+bridge> [ddnet] i'm thinking about what to do next 09:16 <+bridge> [ddnet] I would add the connection from the NetMessage to m_IsSitting now 09:16 <+bridge> [ddnet] Then you would have the serverside complete and can focus on the client implementation 09:17 <+bridge> [ddnet] You can use Cl_ShowOthers for reference 09:17 <+bridge> [ddnet] okay 09:22 <+bridge> [ddnet] gamecontext.cpp? 09:23 <+bridge> [ddnet] Yes 09:23 <+bridge> [ddnet] fokkonaut-sensei 09:23 <+bridge> [ddnet] :greenthing: 09:23 <+bridge> [ddnet] 🤭 09:31 <+bridge> [ddnet] uhh 09:31 <+bridge> [ddnet] rn im just trying to read the entire block of text and trying to think of where to put thi 09:32 <+bridge> [ddnet] just put it below CL_SHOWOTHERS :D 09:32 <+bridge> [ddnet] NETMSGTYPE_CL_SHOWOTHERS 09:32 <+bridge> [ddnet] oh 09:32 <+bridge> [ddnet] now i see it 09:33 <+bridge> [ddnet] 😄 09:33 <+bridge> [ddnet] Thought you found OnMessage() already :D 09:35 <+bridge> [ddnet] i *did* 09:40 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/1017701120103166012/unknown.png 09:42 <+bridge> [ddnet] again your issue 09:42 <+bridge> [ddnet] pChr not initialized 09:42 <+bridge> [ddnet] (+ the netmsg thingy) 09:42 <+bridge> [ddnet] (+ the netmsg thingy issue) 09:42 <+bridge> [ddnet] the red squiggles is just because its not built yet 09:43 <+bridge> [ddnet] Don't forget so to initialize it before using pChr 09:43 <+bridge> [ddnet] @Voxel you can simply use pPlayer->GetCharacter() 09:43 <+bridge> [ddnet] but you should check it first, so put it in an if case, and after it you can use it to access m_IsSitting 09:43 <+bridge> [ddnet] and: pMsg will not have m_Show, instead it will have m_Sit 09:44 <+bridge> [ddnet] oops 09:46 <+bridge> [ddnet] Like this? 09:46 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/1017702623022952448/unknown.png 09:47 <+bridge> [ddnet] Or do I need to actually create a new if statement around the 09:50 <+bridge> [ddnet] better do a new packet with netintany for all animations 09:51 <+bridge> [ddnet] i dont think that's needed though. those are just client side animations 09:51 <+bridge> [ddnet] why do you need pchr->is_sitting 09:51 <+bridge> [ddnet] check 09:52 <+bridge> [ddnet] i mean maybe ddnet will have another ones :troll: 09:52 <+bridge> [ddnet] then they can add it themselves 09:52 <+bridge> [ddnet] another packet? 09:52 <+bridge> [ddnet] for same thing 09:52 <+bridge> [ddnet] please dont pressure me right now this is hurting my head a bit LOL 09:53 <+bridge> [ddnet] nah just want to hear other opinions about new packet 09:53 <+bridge> [ddnet] i mean yeah i think the packet can be expanded, but as of right now it should be fine 09:53 <+bridge> [ddnet] Like that, but also check that pchr is not null 09:53 <+bridge> [ddnet] dont check for m_IsSitting 09:53 <+bridge> [ddnet] And remove the if issitting 09:54 <+bridge> [ddnet] he does 09:54 <+bridge> [ddnet] Tru 09:54 <+bridge> [ddnet] Need coffee 09:54 <+bridge> [ddnet] 09:54 <+bridge> [ddnet] gm 09:54 <+bridge> [ddnet] And just hit build man 09:54 <+bridge> [ddnet] xD 09:54 <+bridge> [ddnet] removed is sitting 09:54 <+bridge> [ddnet] Dont u have ocd with red stuff 09:54 <+bridge> [ddnet] removed is sitting check 09:55 <+bridge> [ddnet] Ur build doesnt need to succeed 09:55 <+bridge> [ddnet] Just do it! 09:55 <+bridge> [ddnet] im worried if i hit build something will go wrong with the servers and itll think im botting 09:55 <+bridge> [ddnet] What 09:55 <+bridge> [ddnet] nope 09:55 <+bridge> [ddnet] it doesnt work like that :troll: 09:56 <+bridge> [ddnet] ok the red stuff is gone 09:56 <+bridge> [ddnet] and white is still here 09:56 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/1017705128435916840/unknown.png 09:57 <+bridge> [ddnet] good 09:57 <+bridge> [ddnet] :greenthing: 09:57 <+bridge> [ddnet] is if-let statement a thing in cpp? 09:58 <+bridge> [ddnet] Cl sit is a bit ambiguous imho, Cl character sit 09:58 <+bridge> [ddnet] Better 09:58 <+bridge> [ddnet] Mobile sux 10:02 <+bridge> [ddnet] @Voxel now to the client side 10:02 <+bridge> [ddnet] yea 10:02 <+bridge> [ddnet] sec 10:16 <+bridge> [ddnet] @Voxel Design question: Should sitting be disabled once you move? You have implemented correct rendering on the clientside already, means a player could simply have IsSitting enabled all the time, and walking/jumping would work fine, until you stand still again then you sit? 10:16 <+bridge> [ddnet] or do you want it so that you manually have to enable sitting again after you walked? 10:16 <+bridge> [ddnet] i think thats a nicer solution 10:16 <+bridge> [ddnet] well, hard to say actually 10:17 <+bridge> [ddnet] I think it would be nicer if it was, if your tee moves from when you're sitting you stand back up 10:17 <+bridge> [ddnet] This also means getting dragged 10:17 <+bridge> [ddnet] yes, but imagine you get dragger 1 block :D 10:17 <+bridge> [ddnet] dragged* 10:18 <+bridge> [ddnet] Maybe stand up as soon as you walk, not as soon as you move in general/get moved? 10:18 <+bridge> [ddnet] I think thats good. 10:19 <+bridge> [ddnet] yeah, that sounds like a good compromise 10:19 <+bridge> [ddnet] @Voxel can you go to the server once again? :D 10:20 <+bridge> [ddnet] character.cpp 10:21 <+bridge> [ddnet] alrighty im in 10:21 <+bridge> [ddnet] go to OnPredictedInput() 10:21 <+bridge> [ddnet] wait 10:21 <+bridge> [ddnet] no. 10:22 <+bridge> [ddnet] Lets do this in Tick() 10:24 <+bridge> [ddnet] actually 10:24 <+bridge> [ddnet] @Voxel DDraceTick() 10:24 <+bridge> [ddnet] Is there a DDraceTick() in character.cpp? 10:24 <+bridge> [ddnet] yes 10:25 <+bridge> [ddnet] you can ctrl+f it 10:25 <+bridge> [ddnet] its in character.h but not in the cpp file 10:25 <+bridge> [ddnet] it is :D 10:25 <+bridge> [ddnet] ctrl+left click it 10:25 <+bridge> [ddnet] oh im stupid 10:25 <+bridge> [ddnet] :P 10:26 <+bridge> [ddnet] im rly sorry u have to sit through this LOL 10:26 <+bridge> [ddnet] okay what you see here is, that when you are frozen it resets your m_Input.m_Direction (left/right) 10:26 <+bridge> [ddnet] not yet sitting :P 10:26 <+bridge> [ddnet] aswell as hook and fire 10:26 <+bridge> [ddnet] yea i see that 10:26 <+bridge> [ddnet] hook and jump* 10:27 <+bridge> [ddnet] okay, so, you should add the check we are going to do below this. 10:27 <+bridge> [ddnet] So that when you are frozen, and press left or right, it doesnt impact starting to stand uip 10:28 <+bridge> [ddnet] I would add something like `if (m_Input.m_Direction != 0) m_IsSitting = false;` 10:28 <+bridge> [ddnet] lets do that for now, and later check if its all working, or if we want to adjust smth 10:28 <+bridge> [ddnet] oke 10:29 <+bridge> [ddnet] https://github.com/ddnet/ddnet/blob/6f62750833f2d0ed9f08f38d709c9beb609d0ab0/src/game/server/entities/character.cpp#L2049 10:29 <+bridge> [ddnet] do it here, or so 10:30 <+bridge> [ddnet] Alright it's in 10:30 <+bridge> [ddnet] Ok. 10:30 <+bridge> [ddnet] Now lets do the clientside? 10:31 <+bridge> [ddnet] Yea 10:31 <+bridge> [ddnet] Have you worked with ddnetCharacter before? 10:31 <+bridge> [ddnet] Ah wait, one thing we forgot 10:31 <+bridge> [ddnet] where you send the ddnetcharacter flag 10:31 <+bridge> [ddnet] You should add a || m_pPlayer->m_Afk check 10:32 <+bridge> [ddnet] so `is_sitting` is either sent when afk or manually sitting 10:33 <+bridge> [ddnet] oh right one second 10:34 <+bridge> [ddnet] wait shouldnt it be if Pchr AND if afk? 10:35 <+bridge> [ddnet] or does being AFK override it? 10:35 <+bridge> [ddnet] i mean in CCharacter::Snap 10:35 <+bridge> [ddnet] where you send the IS_SITTING flag 10:36 <+bridge> [ddnet] `if (m_IsSitting || m_pPlayer->m_Afk)` 10:36 <+bridge> [ddnet] yea yea 10:39 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/1017715855787831306/unknown.png 10:39 <+bridge> [ddnet] i think you messed up both things 10:39 <+bridge> [ddnet] like 10:39 <+bridge> [ddnet] you mixed them together 10:40 <+bridge> [ddnet] fuck 10:40 <+bridge> [ddnet] okay so, the first check you have, put that to where you send the CHARACTERFLAG_IS_SITTING 10:40 <+bridge> [ddnet] and the direction check you keep in DDraceTick 10:43 <+bridge> [ddnet] okay i did that successfully 10:44 <+bridge> [ddnet] now the next step is to have there be a proper bind to it? or is that already taken care of? 10:44 <+bridge> [ddnet] It's not yet 10:44 <+bridge> [ddnet] Do you want to start with that, or with actually receiving the Sitting information? 10:45 <+bridge> [ddnet] well itd be better to have it recieve what we want first so 10:45 <+bridge> [ddnet] well itd be better to have it receive what we want first so 10:46 <+bridge> [ddnet] alright. you can check where the client receives the ddnetcharacter object 10:46 <+bridge> [ddnet] ? 10:46 <+bridge> [ddnet] hmm. when designing a game, you try to communicate information to the players 10:47 <+bridge> [ddnet] if you add a way to make the player communicate being afk without actually being afk, then that signal loses value, right? 10:47 <+bridge> [ddnet] it does not include the afk bubble, and i personally think its a nice touch to be able to just sit down 10:47 <+bridge> [ddnet] Could also be used to indicate "hey guys, i go toilet 5 min" 10:47 <+bridge> [ddnet] And it suits teeworlds very much 10:47 <+bridge> [ddnet] I'd imagine people would spam it like emotes, removing any kind of information from it 10:48 <+bridge> [ddnet] bind "+fire;sit" 10:48 <+bridge> [ddnet] good point 10:48 <+bridge> [ddnet] Well, the afk emote is not spamable 10:48 <+bridge> [ddnet] which is the main indicator for being afk 10:48 <+bridge> [ddnet] "+fire;sit;emote 9" 10:48 <+bridge> [ddnet] i think its 9 10:49 <+bridge> [ddnet] I guess maybe it's not as bad as we still have the zzz, and maybe no intention of removing it 10:49 <+bridge> [ddnet] + the inverted eyes 10:49 <+bridge> [ddnet] the inverted eyes can be bound 10:50 <+bridge> [ddnet] you cant bind the open eyes while being frozen tho 10:50 <+bridge> [ddnet] yes (although that's more of a bug, I guess) 10:50 <+bridge> [ddnet] no, i think thats perfect 10:50 <+bridge> [ddnet] (although that happened more accidentally I guess) 10:50 <+bridge> [ddnet] it indiciates very good that frozne people are speccing or afk 10:50 <+bridge> [ddnet] (although that happened more accidentally I guess, not intentionally) 10:50 <+bridge> [ddnet] (which was one of the main intentions) 10:50 <+bridge> [ddnet] showing pause in freeze 10:51 <+bridge> [ddnet] to avoid fials 10:51 <+bridge> [ddnet] foails 10:51 <+bridge> [ddnet] you think that it was intentional that you couldn't change your eyes to normal in freeze? ^^ 10:51 <+bridge> [ddnet] fails 10:51 <+bridge> [ddnet] definitely 10:51 <+bridge> [ddnet] they were supposed to be closed 10:51 <+bridge> [ddnet] or any other custom eyes 10:51 <+bridge> [ddnet] it seems very unlikely to me. how could you be so sure of that? 10:52 <+bridge> [ddnet] Well, because that is the way it was made :D 10:52 <+bridge> [ddnet] And if they would wanted it differently, it would have been done 10:52 <+bridge> [ddnet] no, the current way is the "path of least resistance" if you don't think about the implications 10:52 <+bridge> [ddnet] you have default eyes where you change everything according to state 10:53 <+bridge> [ddnet] and you have non-default eyes where you don't change according to state 10:53 <+bridge> [ddnet] anyways, i think the behaviour is absolutely perfect 10:53 <+bridge> [ddnet] this has the happy accident of not being able to change your eyes to the open eyes because they're "default" 10:53 <+bridge> [ddnet] yea 10:54 <+bridge> [ddnet] @heinrich5991 it should definitely not change, it avoids many fails for me personally, cuz i dont hammer out tees with open eyes in frz 10:54 <+bridge> [ddnet] huge gameplay+++ 10:54 <+bridge> [ddnet] since it got implemented 10:55 <+bridge> [ddnet] This now makes me think; was making sitting outside of AFK worth it? 10:55 <+bridge> [ddnet] (this is an example of a clear signal, one which cannot be bound) 10:55 <+bridge> [ddnet] (and you say it's great that it cannot be forced) 10:55 <+bridge> [ddnet] Yes, but sitting is a nice touch as i said, and I think its cool to be able to sit without being afk. as i said, it indicates clearly that you did not move or do not move right now 10:56 <+bridge> [ddnet] and: afk is more than visible with the emote 10:56 <+bridge> [ddnet] i wasnt the one who suggested manual sitting, just liked the idea since it suits ddnet 10:56 <+bridge> [ddnet] Ravie also mentioned a possible sit cooldown, so people don't make sit bots that force them to sit throughout the entirety of their gameplay 10:56 <+bridge> [ddnet] yes, that would belong to the server side 10:56 <+bridge> [ddnet] had that in mind too 10:57 <+bridge> [ddnet] I mean you could perhaps extend sitting to /pause and you have a clearer indicator of not being able to respond 10:57 <+bridge> [ddnet] and you can suddenly "bind" /sit 10:57 <+bridge> [ddnet] but you actually can't move during it 10:57 <+bridge> [ddnet] i wouldnt do that, if someone throws you somewhere and u want to react, its very bad gameplay 10:58 <+bridge> [ddnet] Jump to quickly get out of sit 10:58 <+bridge> [ddnet] currently it would be, that you automatically "stand up" once you move 10:58 <+bridge> [ddnet] (walk only) 10:58 <+bridge> [ddnet] Jump to quickly get out of sit, That's my addendum 10:58 <+bridge> [ddnet] that's the point; sit indicates you're not able to respond 10:58 <+bridge> [ddnet] Jump to quickly get out of /sit, That's my addendum 10:58 <+bridge> [ddnet] I know what you mean, but you go around what players would actually really like 10:58 <+bridge> [ddnet] (i.e. the /sit wasn't supposed to be a real command, it's just /pause that also sits) 10:58 <+bridge> [ddnet] actually 10:58 <+bridge> [ddnet] "what players would actually really like" 10:59 <+bridge> [ddnet] sit being only smth visual when you're really afk or paused is the best 10:59 <+bridge> [ddnet] = "what I actually really like" (I'd guess) 10:59 <+bridge> [ddnet] real signals are really good 10:59 <+bridge> [ddnet] we're trying to design a game 10:59 <+bridge> [ddnet] I assume many players would like it, just look at how they liked the emote delay 0 from Chile servers 10:59 <+bridge> [ddnet] "it looks like they have so much fun" 10:59 <+bridge> [ddnet] people said 11:00 <+bridge> [ddnet] to be honest, having it where you cant manually move out of sit is acceptable in my terms. i think people who just chill in maps like water lily would like just sitting down and everything 11:00 <+bridge> [ddnet] yeah, and we still have the afk emote + inverted eyes, which was always enough. I think sitting is just a nice touch to it, which is not a problem to show without being afk/paused 11:01 <+bridge> [ddnet] + u can move ur weapon direction while ur sitting, there is definitely enough difference to actually having the afk flag 11:01 <+bridge> [ddnet] we only have inverted eyes for /pause'd players 11:01 <+bridge> [ddnet] no 11:01 <+bridge> [ddnet] So what I think I want to happen is: 11:01 <+bridge> [ddnet] You sit when you're AFK, in Pause, or use the Sit command, which is like pause except you aren't spectating the map 11:02 <+bridge> [ddnet] would be useful for if someone is doing a part and you want to sit it out until they're done 11:02 <+bridge> [ddnet] yea, but i dont think you should be able to move. 11:03 <+bridge> [ddnet] so, walking resets your sitting state and lets you stand up 11:03 <+bridge> [ddnet] how we have it right now 11:04 <+bridge> [ddnet] I think we should continue like this Voxel, and see other responses. As these design discussions are not much/hard to implement or change later on. They are even serverside mostly, so lets go for it for now I'd say 11:05 <+bridge> [ddnet] You can show the differences etc in the PR later on 11:05 <+bridge> [ddnet] Yeah, we'll continue like this and then think about it more once we hear more voices 11:05 <+bridge> [ddnet] Yeah, we'll continue like this and then think about it more once we hear more voices on this 11:05 <+bridge> [ddnet] Alright, so you fetched the sitting information already? 11:06 <+bridge> [ddnet] thanks for teaching how to do network protocols btw, @fokkonaut 11:06 <+bridge> [ddnet] No problem :) 11:06 <+bridge> [ddnet] i think we all learned something LOL 11:07 <+bridge> [ddnet] oh wait u guys r talking about something different 11:07 <+bridge> [ddnet] He means the teeworlds network protocol and how it works or how to add new things that are sent over the network 11:07 <+bridge> [ddnet] like, without breaking old clients compatibility etc 11:08 <+bridge> [ddnet] like right now the client sends whether it wants to sit or stand up, and the server sends information whether a tee is sitting or not 11:10 <+bridge> [ddnet] breaking compat is a feature 11:10 <+bridge> [ddnet] :justatest: 11:11 <+bridge> [ddnet] So i know I need to do something with `pDDNetCharacter->m_Flags |= CHARACTERFLAG_IS_SITTING` 11:11 <+bridge> [ddnet] Yes, on the clientside though 11:11 <+bridge> [ddnet] So i know I need to do something with `pDDNetCharacter->m_Flags | CHARACTERFLAG_IS_SITTING` 11:11 <+bridge> [ddnet] go to gameclient.cpp, and see how other elements of DDNetCharacter are being handled 11:11 <+bridge> [ddnet] e.g. `m_HasTelegunLaser ` 11:12 <+bridge> [ddnet] You add a boolean to the CClientData m_IsSitting, which you then set based on whether the flag is included in the object. 11:19 <+bridge> [ddnet] Did that. Also Removed the now obsolete boolean IsActive and did this, so that the hammer doesn't look too high when you're holding it 11:19 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/1017725869566988419/unknown.png 11:19 <+bridge> [ddnet] Did that. Also Removed the now obsolete boolean IsActive and did this, so that the hammer doesn't look too high when you're holding it while sitting 11:19 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/1017725869566988419/unknown.png 11:20 <+bridge> [ddnet] I would remove the m_Afk checks around your sitting stuff entirely 11:20 <+bridge> [ddnet] Because m_IsSitting is always set to true when you are afk :) 11:20 <+bridge> [ddnet] (by the server) 11:21 <+bridge> [ddnet] But would you want the hammer tilted back when you're sitting and not AFK? 11:22 <+bridge> [ddnet] Ah, probably not. But then I would still do the checks the other way around. Everthing related to sitting, use m_IsSitting, and for afk specific stuff do a separate m_Afk check 11:22 <+bridge> [ddnet] because you can be sitting without being afk. but not being afk without sitting 11:24 <+bridge> [ddnet] And make sure to reset m_IsSitting to false in CClientData::Reset 11:24 <+bridge> [ddnet]