00:00 <+bridge> [ddnet] Hello good night I have a problem that when I go to any ddnet map it keeps connecting infinite (I'm from Brazil, Alagoas) and it doesn't connect. @Moderator 00:24 <+bridge> [ddnet] something wrong with the mastersevers? I can't connect my homeserver oO `[2022-06-16 00:22:53][register/6/ipv6]: ERROR: the master server reports that clients can not connect to this server. 00:24 <+bridge> [ddnet] [2022-06-16 00:22:53][register/6/ipv6]: ERROR: configure your firewall/nat to let through udp on port 8303.` 00:24 <+bridge> [ddnet] And yes i know, i need to have the portforwarding, but I have already done this 00:30 <+bridge> [ddnet] is it only ipv6 that it's complaining about? 00:30 <+bridge> [ddnet] then you might only have allowed your port on ipv4? 00:30 <+bridge> [ddnet] `[2022-06-16 00:30:06][http]: https://master1.ddnet.tw/ddnet/15/register failed. libcurl error: The requested URL returned error: 400` I have never seen this one 00:31 <+bridge> [ddnet] yes only ipv6 is complaining 00:34 <+bridge> [ddnet] that shouldn't happen 00:34 <+bridge> [ddnet] on newest version? 00:59 <+bridge> [ddnet] kinda, on a modded version 00:59 <+bridge> [ddnet] just material modded, not network 08:22 <+ChillerDragon> why are clannames sometimes chop off in scoreboard and suffied with "..." ? 08:23 <+bridge> [ddnet] bcs the scoreboard is too small 08:23 <+bridge> [ddnet] or the font size is too big 08:24 <+ChillerDragon> but it used to fit in there? same resolution and font size 08:24 <+bridge> [ddnet] :/ 08:25 <+bridge> [ddnet] i called it XD 08:25 <+ChillerDragon> ofc u did 08:25 <+ChillerDragon> u also called my 15% amd gain o.O 08:25 <+bridge> [ddnet] i just knew someone would be affected by it 😄 08:25 <+bridge> [ddnet] ez amd 08:26 <+ChillerDragon> https://zillyhuhn.com/cs/.1655360776.png 08:26 <+ChillerDragon> those two bois were cut off a sec ago. Probably some dudes joined and it switched to the two sided scorevoard with smaller font then it fully displayed their clans again 08:27 <+bridge> [ddnet] ez 08:27 <+ChillerDragon> not very long clans imo 08:27 <+ChillerDragon> i assume this "fix" was made for our friend the "WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW" xD 08:28 <+bridge> [ddnet] and clan is most important too 😄 08:28 <+ChillerDragon> well this poor ad bridge cant spread the virus when the last characters are visible so its business critical 08:28 <+ChillerDragon> anrent' 08:32 <+bridge> [ddnet] i have to say, i dont even find a bigger scoreboard that ugly 08:32 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/986880968654721024/unknown.png 08:32 <+bridge> [ddnet] (text not fixed) 08:33 <+bridge> [ddnet] i think it looks fine too 08:34 <+bridge> [ddnet] no reason to have it so tiny since it already obstructs the screen 09:07 <+bridge> [ddnet] If the clan is empty, you may can render a bigger name 🤔 but that's just me being crazy, Keep it simple stupid 10:22 <+bridge> [ddnet] Can anyone review https://github.com/ddnet/ddnet/pull/5412 ? Otherwise it will conflict with every translation PR 10:50 <+bridge> [ddnet] In a community that loves their weird UB, I expect no less than 3 people getting affected badly by any change 10:50 <+bridge> [ddnet] xD tru story 10:51 <+bridge> [ddnet] I think the only change I never got any complaints with was the http map downloader 10:52 <+bridge> [ddnet] For those of you that haven't heard about Bitcoin and those that have heard about Bitcoin and are interested in investing on it contact me and I will teach you the full details of it so that you can start making your profit 10:54 <+bridge> [ddnet] lmao, chillerdragon on attention seeking again 10:57 <+ChillerDragon> more like daydrinking again 10:57 <+ChillerDragon> did it ping u 10 times again and sent u 10 mails? xd 11:00 <+bridge> [ddnet] sadly u forgot to ping me 11:43 <+bridge> [ddnet] @louis do you want me to write something for #📬submit-skins ? nothing fancy though 11:52 <+bridge> [ddnet] does it work in lagacy display resolutions? 11:52 <+bridge> [ddnet] does it work in legacy display resolutions? 11:52 <+bridge> [ddnet] its smaller than 2 scoreboards 11:55 <+bridge> [ddnet] there was also one suggestion to just display the clan below the player name ^^ would also work 11:55 <+bridge> [ddnet] <.< 11:55 <+bridge> [ddnet] most ppl only read clans in scoreboard 11:55 <+bridge> [ddnet] xDDD 11:55 <+bridge> [ddnet] it should be special 11:55 <+bridge> [ddnet] I normaly never read clan ^^ 11:55 <+bridge> [ddnet] i always read them 11:55 <+bridge> [ddnet] I normally never read clan ^^ 11:56 <+bridge> [ddnet] but not in the nameplate 11:56 <+bridge> [ddnet] only in scoreboard 11:56 <+bridge> [ddnet] and in vanilla mods when round is over 11:56 <+bridge> [ddnet] and u are first place 11:56 <+bridge> [ddnet] u see, ah nice he's from that clan 11:56 <+bridge> [ddnet] ^^ 11:57 <+bridge> [ddnet] yes probably some use it ... At least all players that use clans seriously 11:57 <+bridge> [ddnet] yeah 11:59 <+bridge> [ddnet] @Chairn Is it ok to address your refactoring requests in another PR. Because they are not specific to my PR, but the problem was there already before 😄 Or do you want me that I scan somhow the code for all wrong array prefixes. And the refactoring of the asset menu should also be done in a more serious PR. 12:01 <+bridge> [ddnet] you could change the array prefixes only in the structs you added 12:02 <+bridge> [ddnet] @c0d3d3v why do you think passing the version to a function `SendChatTarget` is cleaner than doing the version check at the call site? 12:02 <+bridge> [ddnet] it seems to me that it's better to do the check locally, you immediately see what it does 12:03 <+bridge> [ddnet] you don't get that from a random parameter of a function 12:06 <+bridge> [ddnet] But I do get it from the parameter. My IDE tells me the name of the parameter, and that is very verbose written. 12:07 <+bridge> [ddnet] ... ok 12:07 <+bridge> [ddnet] I don't get that in my coding environment, and it's also not visible on github, etc. 12:07 <+bridge> [ddnet] in git diffs 12:08 <+bridge> [ddnet] Also the version we add as parameter is verbose. We all know it is a Enum for version number... 12:08 <+bridge> [ddnet] Do you not think it is code duplication? 12:08 <+bridge> [ddnet] To add everywhere the same condition 12:08 <+bridge> [ddnet] and even if we had explicit parameter passing like `SendChatTarget(1, OnlyForVersionGreaterThan=5)`, it seems weird to not just check it locally 12:08 <+bridge> [ddnet] Asks for review, merges anyway lol 12:09 <+bridge> [ddnet] I mean you can add a function for specifically this if you absolutely want to, but it's just one if everywhere, no? 12:09 <+bridge> [ddnet] murpi reviewed it 12:09 <+bridge> [ddnet] yeah and I found at least 3 issues 🙈 12:09 <+bridge> [ddnet] to me, a single if is clearer than a parameter to some function, where I have to read some non-local code 12:09 <+bridge> [ddnet] 25 conditions around the same function, only difrent message to send 12:10 <+bridge> [ddnet] I'd prefer `if(x < 5) DoFunction()` over `DoFunctionIfLessThan(5)` 12:11 <+bridge> [ddnet] the left is a programming language native construct that is easy to understand 12:11 <+bridge> [ddnet] But why 12:11 <+bridge> [ddnet] the right thing is a function that could do anything 12:12 <+bridge> [ddnet] You should not do checks for something 25 times that should be done by the worker that needs to carry out the operation 12:12 <+bridge> [ddnet] (if you absolutely want to, you could add a function that does what you want, but I think overloading the `SendChatTarget` function isn't really nice) 12:12 <+bridge> [ddnet] but what does "send chat target" have to do with version checks? 12:12 <+bridge> [ddnet] Why we then added the flag field to that function 12:12 <+bridge> [ddnet] to send some messages to version 6 cleints and some to version 7 12:13 <+bridge> [ddnet] thats the same thing 12:13 <+bridge> [ddnet] should I also remove the flags? 12:14 <+bridge> [ddnet] I could also add only one flag to that flag field 12:14 <+bridge> [ddnet] xD do not send to that specific version 12:15 <+bridge> [ddnet] I guess a flag there for OLDHUD would be fine-ish 12:15 <+bridge> [ddnet] the CHAT_SIX stuff at least uses the -1 thing, i.e. it can't simply be lifted out of the function 12:15 <+bridge> [ddnet] @Not Keks I reviewed on the old branch, I posted the veiew in the new one ^.^ 12:16 <+bridge> [ddnet] if you want, you can also use my pr and fix more stuff 12:16 <+bridge> [ddnet] i only skipped through them and fixed some obvious stuff 12:17 <+bridge> [ddnet] havent looked deeper into it, i kinda also dont really like some "forced" translations 12:17 <+bridge> [ddnet] Like "Karte" instead of "Map" 12:17 <+bridge> [ddnet] nobody uses that in german 12:17 <+bridge> [ddnet] Your code style is really strange xD why would I write everything 20times, if I could do the same thing with only one argument more. 12:17 <+bridge> [ddnet] Its the same in the asset menu. Every second line is duplication, If I would refactoring it, I would not like to have any duplication at all. 12:18 <+bridge> [ddnet] its not always so easy 12:18 <+bridge> [ddnet] it already uses templates to minimize some code 12:18 <+bridge> [ddnet] time vs effort 12:18 <+bridge> [ddnet] @c0d3d3v I don't like to put unrelated concerns into functions, especially if they can easily be factored out 12:19 <+bridge> [ddnet] I prefer DoX and DoY over DoXAndY 12:19 <+bridge> [ddnet] alternatively you could use lambdas :p 12:20 <+bridge> [ddnet] @Essigautomat can you elaborate where you want to use lambdas here? 12:20 <+bridge> [ddnet] I would like OOP more then templates, but seems like I'm an other generation :/ 12:20 <+bridge> [ddnet] in assets it makes sense 😄 12:20 <+bridge> [ddnet] That was a bad joke 🙈 sorry 12:20 <+bridge> [ddnet] but what do u want to OOP? 12:21 <+bridge> [ddnet] lambdas can do some magic here 12:21 <+bridge> [ddnet] at least to minimize code 12:21 <+bridge> [ddnet] every tab uses the same method... 12:21 <+bridge> [ddnet] dunno about readability 12:21 <+bridge> [ddnet] doesnt that sound good? xd 12:23 <+bridge> [ddnet] e.g. would you refactor this code: 12:23 <+bridge> [ddnet] 12:23 <+bridge> [ddnet] ```c++ 12:23 <+bridge> [ddnet] char aBuff[IO_MAX_PATH_LENGTH]; 12:23 <+bridge> [ddnet] 12:23 <+bridge> [ddnet] if(str_comp(pAssetItem->m_aName, "default") == 0) 12:23 <+bridge> [ddnet] { 12:23 <+bridge> [ddnet] str_format(aBuff, sizeof(aBuff), "%s.png", pAssetName); 12:23 <+bridge> [ddnet] CImageInfo ImgInfo; 12:23 <+bridge> [ddnet] if(pGraphics->LoadPNG(&ImgInfo, aBuff, IStorage::TYPE_ALL)) 12:23 <+bridge> [ddnet] { 12:23 <+bridge> [ddnet] pAssetItem->m_RenderTexture = pGraphics->LoadTextureRaw(ImgInfo.m_Width, ImgInfo.m_Height, ImgInfo.m_Format, ImgInfo.m_pData, ImgInfo.m_Format, 0); 12:23 <+bridge> [ddnet] pGraphics->FreePNG(&ImgInfo); 12:23 <+bridge> [ddnet] } 12:23 <+bridge> [ddnet] } 12:23 <+bridge> [ddnet] else 12:23 <+bridge> [ddnet] { 12:23 <+bridge> [ddnet] str_format(aBuff, sizeof(aBuff), "assets/%s/%s.png", pAssetName, pAssetItem->m_aName); 12:23 <+bridge> [ddnet] CImageInfo ImgInfo; 12:23 <+bridge> [ddnet] if(pGraphics->LoadPNG(&ImgInfo, aBuff, IStorage::TYPE_ALL)) 12:23 <+bridge> [ddnet] { 12:23 <+bridge> [ddnet] pAssetItem->m_RenderTexture = pGraphics->LoadTextureRaw(ImgInfo.m_Width, ImgInfo.m_Height, ImgInfo.m_Format, ImgInfo.m_pData, ImgInfo.m_Format, 0); 12:23 <+bridge> [ddnet] pGraphics->FreePNG(&ImgInfo); 12:23 <+bridge> [ddnet] } 12:23 <+bridge> [ddnet] else 12:23 <+bridge> [ddnet] { 12:23 <+bridge> [ddnet] str_format(aBuff, sizeof(aBuff), "assets/%s/%s/%s.png", pAssetName, pAssetItem->m_aName, pAssetName); 12:23 <+bridge> [ddnet] if(pGraphics->LoadPNG(&ImgInfo, aBuff, IStorage::TYPE_ALL)) 12:23 <+bridge> [ddnet] { 12:23 <+bridge> [ddnet] pAssetItem->m_RenderTexture = pGraphics->LoadTextureRaw(ImgInfo.m_Width, ImgInfo.m_Height, ImgInfo.m_Format, ImgInfo.m_pData, ImgInfo.m_Format, 0); 12:24 <+bridge> [ddnet] pGraphics->FreePNG(&ImgInfo); 12:24 <+bridge> [ddnet] I would think so. If I have one class that I init with specif parameters, asset name, title ... path.. And init for example 5 objects that belong to the asset menu tab, then I have only one class with only one set of functions 12:24 <+bridge> [ddnet] might look like its lot of same code 12:24 <+bridge> [ddnet] but in the end its still a big ddifnfernt 12:24 <+bridge> [ddnet] but for example entities allow dirs or PNGs 12:24 <+bridge> [ddnet] while other assets only allow PNGs 12:24 <+bridge> [ddnet] but go ahead and refactor it 12:24 <+bridge> [ddnet] but in the end its still a bit ddifnfernt 12:24 <+bridge> [ddnet] all use the same function... could be one function of a asset_tab_class 12:24 <+bridge> [ddnet] https://cdn.discordapp.com/attachments/293493549758939136/986939257224593488/unknown.png 12:24 <+bridge> [ddnet] (except for enteties) 12:24 <+bridge> [ddnet] thats a spot where i nowadays would use lambdas 12:24 <+bridge> [ddnet] or templates 12:25 <+bridge> [ddnet] but why classes? 12:25 <+bridge> [ddnet] yes thats whhy I would use OOP instead of templates 12:25 <+bridge> [ddnet] well anyway, just do it 12:25 <+bridge> [ddnet] `void LoadPNGFromPath(char* aBuf, idkthetype* RenderTexture)` 12:25 <+bridge> [ddnet] not now 12:25 <+bridge> [ddnet] the reason is simple: 12:25 <+bridge> [ddnet] its not worth the effort 12:26 <+bridge> [ddnet] in the past at least 12:26 <+bridge> [ddnet] now we have extras and HUD 12:26 <+bridge> [ddnet] I only want to finish the HUD stuff. Refactoring can be done later xD 12:26 <+bridge> [ddnet] see 12:26 <+bridge> [ddnet] thats my point 12:27 <+bridge> [ddnet] its always a question of time 12:27 <+bridge> [ddnet] But there would be no reason to refactor it, if it would have been oop in first place... 12:27 <+bridge> [ddnet] but ye everything is historicly groun 12:27 <+bridge> [ddnet] grown* 12:27 <+bridge> [ddnet] until u need smth the other stuff doesnt need 12:27 <+bridge> [ddnet] not like u never refactor OOP 12:27 <+bridge> [ddnet] first there was only a entities tab... so ye would not have made sense 12:28 <+bridge> [ddnet] just to be clear i'd use OOP in many places always depends if its worth it 12:29 <+bridge> [ddnet] btw this is actually a good case where i'd bind parameters 12:29 <+bridge> [ddnet] but e.g. ListDirectory doesnt allow this 12:29 <+bridge> [ddnet] it only allows C functions 12:30 <+bridge> [ddnet] so also refactor this ;P 12:31 <+bridge> [ddnet] but it allows a user 12:31 <+bridge> [ddnet] so i guess u can hack in an object 12:31 <+bridge> [ddnet] So should I remove the flags too? 12:31 <+bridge> [ddnet] Or better just tell me what I should do. I do not fight anymore ^^ I will do it. 12:37 <+bridge> [ddnet] IMO, you can move it to flags, you can create another function, or check it locally 13:10 <+bridge> [ddnet] @c0d3d3v I didnt know what exactly you meant yesterday I think, but I think a flag for the freezebar from the server aswell as a flag for the stars to be rendered clientside with the ninja skin will be the way to go. Either you can add it to your pr, or I would add it for you to copy 13:12 <+bridge> [ddnet] Then we could simply add a chat command to toggle and a client option that sends this option ? 13:12 <+bridge> [ddnet] Idk:( 13:13 <+bridge> [ddnet] @heinrich5991 lets make a vote :( 13:13 <+bridge> [ddnet] Democracy 13:14 <+bridge> [ddnet] perhaps we could get an actual freeze animation 13:14 <+bridge> [ddnet] but I don't have a good idea for it 13:15 <+bridge> [ddnet] how to do it with arbitrarily shaped skins 13:16 <+bridge> [ddnet] there were thoughts of an "ice" block above the skin, also you could simply color the player different and add particles (just some thoughts) 13:16 <+bridge> [ddnet] 😭 13:17 <+bridge> [ddnet] yes, but where do we get an ice block that fits arbitrary skins? ^^ 13:18 <+bridge> [ddnet] this one should do: https://static.wikia.nocookie.net/enfuturama/images/7/74/GiantIceCube.jpg/revision/latest?cb=20090629004813 13:18 <+bridge> [ddnet] @heinrich5991 I might have a very valid argument 13:18 <+bridge> [ddnet] Look 13:19 <+bridge> [ddnet] jokes aside, aren't skins limited in their size? 13:19 <+bridge> [ddnet] I personally always played with show ninja 0. 13:19 <+bridge> [ddnet] Is that now also impossible for freeze? 13:19 <+bridge> [ddnet] i really liked the combination of ninja weapon, normal skin, and the stars 13:20 <+bridge> [ddnet] That way I could always see who is who in freeze 13:20 <+bridge> [ddnet] and I could better decide, so its part of my gameplay. 13:20 <+bridge> [ddnet] that would also be served by putting an ice block around people, no? 13:21 <+bridge> [ddnet] No, i am colorblind and cant see colors on first frame 13:21 <+bridge> [ddnet] I need to inspect colors a bit in order to see them or to differntiatw 13:21 <+bridge> [ddnet] thats why it always helped me 13:22 <+bridge> [ddnet] the ice block would probably change the color a bit. that would make it harder to distinguish? 13:23 <+bridge> [ddnet] At least during fast gameplay, yes. 13:23 <+bridge> [ddnet] And when names are cramped together tee by tee, i can also not view them 13:23 <+bridge> [ddnet] I imagine a freezebar in such situations as very ugly and uncomforting aswell 13:24 <+bridge> [ddnet] I think the freeze bar can be disabled when the tee is still in freeze 13:24 <+bridge> [ddnet] thats good 13:25 <+bridge> [ddnet] But yeah, the ninja + real skin was epic for me 13:25 <+bridge> [ddnet] + helped 13:26 <+bridge> [ddnet] I would find it great if we could get away from ninja and move to something freezy 13:26 <+bridge> [ddnet] sure, but its such a good way of seeing the tee in freezepits 13:27 <+bridge> [ddnet] as the skin is rendered without any extra layers 13:27 <+bridge> [ddnet] just the ninja weapon behind it, which could be "removed" 13:27 <+bridge> [ddnet] maybe that would be a toggleable option @c0d3d3v ? rendering normal skin in freeze, with new freeze particles and so on, and maybe the stars? 13:29 <+bridge> [ddnet] please don't add more options 13:29 <+bridge> [ddnet] why do you want to have the stars, specifically? 13:29 <+bridge> [ddnet] they don't seem to add anything 13:29 <+bridge> [ddnet] mostly design, but yea, i think i can live without them 13:30 <+bridge> [ddnet] but 13:30 <+bridge> [ddnet] rendering normal skin as frozen is important gameplay!! 13:31 <+bridge> [ddnet] if we do decide to add it, the burden shouldn't be on @c0d3d3v to add it 13:31 <+bridge> [ddnet] (because this is precisely why options are bad, they put burden on people changing things) 13:31 <+bridge> [ddnet] i sed 13:31 <+bridge> [ddnet] tw just died today 13:31 <+bridge> [ddnet] imagine again ddnet with moving tiles, so much more new map designs 13:32 <+bridge> [ddnet] @fokkonaut tw never dies 13:32 <+bridge> [ddnet] The cleanest most work intense solution might be a frozen skin for each skin. And if you don't possess the frozen version, it defaults back to the default skin frozen version. But I think you'd gain to little for all the work 13:32 <+bridge> [ddnet] but 13:32 <+bridge> [ddnet] 2054 i'll host my v0.14 server 13:32 <+bridge> [ddnet] ye same but 13:32 <+bridge> [ddnet] like 13:32 <+bridge> [ddnet] :/ 13:33 <+bridge> [ddnet] i want to update my client always, but those things make it hard for me to update i am honest 13:34 <+bridge> [ddnet] @heinrich5991 we even have a config for the old chat system? why? because some people might prefer it. And why wouldnt we allow it in this case? 13:34 <+bridge> [ddnet] when there is even a real reason, because it heavily affects gameplay 13:34 <+bridge> [ddnet] and especially in teeworlds single gameplay changes can affect your whole play style :/ 13:35 <+bridge> [ddnet] I think you're overstating this design change a lot. it'd probably be "just normal" in a month 13:35 <+bridge> [ddnet] i know what you mean, but i really need skin visibility 13:36 <+bridge> [ddnet] We have a config for the old chat because I didn't want to get shot by konsti on my way to the supermarket 13:36 <+bridge> [ddnet] now be scared of me ! 13:36 <+bridge> [ddnet] :pepeH: 13:55 <+bridge> [ddnet] the CTuneParams class is so ugly, as soon as you add a virtual function, it's size is different and some other related code breaks 13:58 <+bridge> [ddnet] the CTuneParams class is so ugly, as soon as you add a virtual function, its size is different and some other related code breaks 13:58 <+bridge> [ddnet] add a function for the size and use that in the breaking parts 14:00 <+bridge> [ddnet] doesn't work, because it gets interpreted into an int array and the sequence might be compiler/os depended, idk 14:00 <+bridge> [ddnet] what approach did you take? 14:01 <+bridge> [ddnet] to fix it? Inherit from it and add the virtual functions in the derived class 14:02 <+bridge> [ddnet] can i see it? 14:03 <+bridge> [ddnet] ? 14:03 <+bridge> [ddnet] ``` 14:03 <+bridge> [ddnet] class CMatDefault : public CTuneParams //CTuneParams is not allowed to contain virtual functions 14:03 <+bridge> [ddnet] { 14:03 <+bridge> [ddnet] public: 14:03 <+bridge> [ddnet] CMatDefault() = default; 14:03 <+bridge> [ddnet] virtual int GetSkidSound(); 14:03 <+bridge> [ddnet] virtual float GetSkidThreshold() { return 500.0f; } 14:03 <+bridge> [ddnet] virtual float GetDynamicAcceleration(float Velocity) { return m_GroundControlAccel; } 14:03 <+bridge> [ddnet] }; 14:03 <+bridge> [ddnet] ``` 14:04 <+bridge> [ddnet] tbh that's less of a fix and more of a workaround 😄 14:04 <+bridge> [ddnet] i dont know what exactly the problem is, i believe 14:06 <+bridge> [ddnet] this is a very evil function (which is actually wrong, too): https://github.com/ddnet/ddnet/blob/edab7c0e8c25ea52384801674f05dcd3b12aaca8/src/game/gamecore.h#L56 14:08 <+bridge> [ddnet] also this part, it's equally bad (and also wrong) https://github.com/ddnet/ddnet/blob/edab7c0e8c25ea52384801674f05dcd3b12aaca8/src/game/client/gameclient.cpp#L690 14:08 <+bridge> [ddnet] ah! 14:08 <+bridge> [ddnet] i see 14:08 <+bridge> [ddnet] adding a virtual function to CTuneParams makes the class bigger and in turn breaks this code parts, also in both cases it should be sizeof(CTuneParams) 14:09 <+bridge> [ddnet] adding a virtual function to CTuneParams makes the class bigger and in turn breaks this code parts, also in both cases it should be sizeof(CTuneParams) instead of sizeof(int) 14:09 <+bridge> [ddnet] yep 14:37 <+bridge> [ddnet] genius 14:44 <+bridge> [ddnet] Yes, that thing is absolutely awful 14:45 <+bridge> [ddnet] Smh c++ 14:45 <+bridge> [ddnet] Not C++'s fault matricks decided he didnt care what the standard has to say 14:46 <+bridge> [ddnet] :PES3_SusAlt: 14:46 <+bridge> [ddnet] when it's nearly 15 o'clock, you programm all day and notice, that you may need something to eat 14:46 <+bridge> [ddnet] when it's nearly 15 o'clock, you programm all day and notice, that you may need something to breakfast 14:46 <+bridge> [ddnet] @heinrich5991 is there an easy way for me to implement the reliable server registering without applying the whole register refactor? 14:47 <+bridge> [ddnet] I usually notice when I get a massive hunger headache :D 14:48 <+bridge> [ddnet] exactly 🙈 14:48 <+bridge> [ddnet] you only need to do regular post requests, see the description of this PR how they look like: https://github.com/ddnet/ddnet/pull/5064 14:49 <+bridge> [ddnet] if youre willing to, it would be nice 14:50 <+bridge> [ddnet] thanks, uhm :D 14:51 <+bridge> [ddnet] xd 14:52 <+bridge> [ddnet] i'll see if i can get it to work 14:57 <+bridge> [ddnet] @murpi mvp 14:58 <+bridge> [ddnet] when learn python programming @louis? 😛 15:07 <+bridge> [ddnet] ```py 15:07 <+bridge> [ddnet] import discord 15:07 <+bridge> [ddnet] if messageIsValid() 15:07 <+bridge> [ddnet] addReactions() 15:07 <+bridge> [ddnet] ``` 15:07 <+bridge> [ddnet] i think that should work 15:08 <+bridge> [ddnet] missing colon in line 2 15:08 <+bridge> [ddnet] but otherwise great, let's ship it 😉 15:10 <+bridge> [ddnet] i tried to write a python script to automatically generate gores maps that wouldnt be too distinguishable from a human-made map 15:10 <+bridge> [ddnet] it got pretty disgusting quickly though 15:14 <+bridge> [ddnet] @louis I did something similar, but in C++ and for dungeons, if you want the repo tell me ^^ 15:14 <+bridge> [ddnet] I want to take a look at it 15:14 <+bridge> [ddnet] oh ghod 15:15 <+bridge> [ddnet] oh god 15:37 <+bridge> [ddnet] i force pushed to this 15:37 <+bridge> [ddnet] https://github.com/ddnet/ddnet/pull/5424 15:39 <+bridge> [ddnet] @cauldron I let the CI run. if there's style checker problems, can I add them to your PR so you don't have to deal with it? 15:40 <+bridge> [ddnet] sure, but this time i let the python script run ;D 15:41 <+bridge> [ddnet] ah nice 🙂 15:41 <+bridge> [ddnet] https://github.com/ddnet/ddnet/pull/5423 15:41 <+bridge> [ddnet] https://github.com/ddnet/ddnet/pull/5424 15:41 <+bridge> [ddnet] the if looked a bit weird, I hadn't guessed that this is what clang-format wants 15:42 <+bridge> [ddnet] well, maybe check again, and maybe it's not the best way, but in the range of the python script. i put it on newline but the script put it back on one line. 15:52 <+bridge> [ddnet] \❌ 16:05 <+bridge> [ddnet] how to add the clang-format or the python fix styling script to vscode, so that is formats everytime you save? 16:08 <+ChillerDragon> Is it possible that there is no code for movin a directory in the storage code? :( 16:08 <+bridge> [ddnet] idk, maybe https://marketplace.visualstudio.com/items?itemName=xaver.clang-format @cauldron 16:08 <+bridge> [ddnet] ChillerDragon: does RenameFile not work? 16:08 <+ChillerDragon> it sounds like file i didnt test it 16:09 <+ChillerDragon> also in the `rename` manpage it talks about files 16:09 <+bridge> [ddnet] `rename` isn't limited to files in linux 16:09 <+ChillerDragon> but yea isnt everything a file in linux? 16:09 <+ChillerDragon> even folders? 16:09 <+bridge> [ddnet] yes 16:09 <+ChillerDragon> xd 16:09 <+ChillerDragon> ok maybe renamefile works then 16:09 <+bridge> [ddnet] idk about windows though 16:09 <+bridge> [ddnet] force pushed again 16:09 <+bridge> [ddnet] but I guess it's fine there, as well 16:09 <+ChillerDragon> yikers 16:10 <+ChillerDragon> `MoveFileExW` 16:10 <+ChillerDragon> windows .-. 16:10 <+bridge> [ddnet] it's backward compatible 😉 16:10 <+bridge> [ddnet] I mean, on linux the syscall is called `renameat2` 😛 16:11 <+ChillerDragon> yea should work 16:11 <+ChillerDragon> fingers crossed 16:12 <+bridge> [ddnet] heinrich is if checking from left to right or right to left? 16:13 <+bridge> [ddnet] <陪我> @louis done 16:13 <+bridge> [ddnet] <陪我> the bot should auto-react and auto-yeet all messages not following the format 16:14 <+bridge> [ddnet] its not "sheep" by unknown? xdd 16:14 <+bridge> [ddnet] @cauldron left to right 16:14 <+bridge> [ddnet] also get rid of the newline in the condition, please @cauldron 16:14 <+bridge> [ddnet] <陪我> did you make it? I can't remember 😄 16:14 <+bridge> [ddnet] i found it but idk who made it 16:17 <+bridge> [ddnet] <陪我> I spent like an hour to figure out how to restrict certain reactions for specific roles, just to learn we can restrict reactions from discord directly 16:17 <+bridge> [ddnet] <陪我> emotional damage 16:17 <+bridge> [ddnet] and also what comes first || or && because i did ( cond1 || (cond2 && cond3)) 😅 16:18 <+bridge> [ddnet] and also what comes first `|| or && because i did ( cond1 || (cond2 && cond3))` 😅 16:18 <+bridge> [ddnet] and also what comes first `|| or &&` because i did `( cond1 || (cond2 && cond3))` 😅 16:18 <+bridge> [ddnet] this evaluates left to right 16:18 <+bridge> [ddnet] it first checks cond1, if it's true, it stops evaluating 16:18 <+bridge> [ddnet] otherwise it checks cond2, if it's false, it stops evaluating 16:19 <+bridge> [ddnet] otherwise it checks cond3\ 16:19 <+bridge> [ddnet] otherwise it checks cond3 16:19 <+bridge> [ddnet] yes, but if i do `(cond1 || cond2 && cond3)` what then? 16:19 <+bridge> [ddnet] i guess `&&` comes first because its 'stronger"? 16:19 <+bridge> [ddnet] i guess `&&` comes first because its 'stronger'? 16:20 <+bridge> [ddnet] `(cond1 || cond2 && cond3)` is the same as `(cond1 || (cond2 && cond3))` 16:20 <+bridge> [ddnet] but write parentheses, it makes the intent clearer ^^ 16:21 <+bridge> [ddnet] but that would be different just for the record `((cond1 || cond2) && cond3)` 16:22 <+bridge> [ddnet] yes 16:22 <+bridge> [ddnet] ok 16:23 <+bridge> [ddnet] thank u ^^ 16:59 <+ChillerDragon> is it possible that clang tidy has false positives? 17:00 <+bridge> [ddnet] please be more specific 17:00 <+bridge> [ddnet] probably yes 17:00 <+ChillerDragon> woot how 17:00 <+ChillerDragon> i thought its da best of the best 17:01 <+bridge> [ddnet] its a static analyzer 17:01 <+bridge> [ddnet] it sometimes assumes stuff 17:01 <+bridge> [ddnet] the only one I know is about object slicing (if you want it) 17:01 <+bridge> [ddnet] ```C 17:01 <+bridge> [ddnet] CCharacter *pChar = ChatHelper()->GameClient()->m_GameWorld.GetCharacterByID(ChatHelper()->GameClient()->m_LocalIDs[g_Config.m_ClDummy]); 17:01 <+bridge> [ddnet] if(pChar) 17:01 <+bridge> [ddnet] continue; 17:01 <+bridge> [ddnet] vec2 Self = pChar->m_Pos; 17:01 <+bridge> [ddnet] ``` 17:01 <+bridge> [ddnet] yeah 17:02 <+bridge> [ddnet] thats just wrong 17:02 <+bridge> [ddnet] if(pchar) continue 17:02 <+bridge> [ddnet] looks really wrong 17:02 <+bridge> [ddnet] ah lol 17:02 <+bridge> [ddnet] i want ! 17:02 <+bridge> [ddnet] xd 17:02 <+bridge> [ddnet] xd 17:02 <+bridge> [ddnet] yea i knew it 17:02 <+bridge> [ddnet] never clang gets something so simple wrong 17:03 <+bridge> [ddnet] if the pChar comes from other libs for example it might actually do this 17:03 <+bridge> [ddnet] but the compiler should see it too actually 17:03 <+bridge> [ddnet] you can overwrite the pointer operator and make the code above work 17:04 <+bridge> [ddnet] dunno if that works, but best idea 2022 17:04 <+bridge> [ddnet] just invert all logic 17:04 <+bridge> [ddnet] jupstar u got some free music for me? 17:04 <+bridge> [ddnet] let me google CC0 music 17:04 <+bridge> [ddnet] omagawd 17:04 <+bridge> [ddnet] not CC0 17:04 <+bridge> [ddnet] free to listen to 17:05 <+bridge> [ddnet] https://en.wikipedia.org/wiki/File:Anthem_of_Europe_(US_Navy_instrumental_short_version).ogg 17:05 <+bridge> [ddnet] here 17:05 <+bridge> [ddnet] public domain 17:05 <+bridge> [ddnet] lmao my pipeline was actually catching the issue as well but my tests are not that ellaborate xd 17:05 <+bridge> [ddnet] omagawd 17:05 <+bridge> [ddnet] something thats nice to listen to 17:06 <+bridge> [ddnet] u dont like bethooven? 17:06 <+bridge> [ddnet] bitsh wat u would listen to 17:06 <+bridge> [ddnet] niet 17:06 <+bridge> [ddnet] suka 17:06 <+bridge> [ddnet] its the best german musican 17:06 <+bridge> [ddnet] all nazis 17:06 <+bridge> [ddnet] back them the world was smth else 17:07 <+bridge> [ddnet] send me ur fav playlist or riot 17:07 <+bridge> [ddnet] ok let me see 17:07 <+bridge> [ddnet] i like anime soundtracks alot, bcs im weeb 17:07 <+bridge> [ddnet] game music also nice often 17:08 <+bridge> [ddnet] i am more instrumental guy u know 17:09 <+bridge> [ddnet] try me 17:09 <+bridge> [ddnet] u hear 2 songs at the same time 17:09 <+bridge> [ddnet] and call it a new song 17:11 <+ChillerDragon> ping 17:12 <+bridge> [ddnet] pong 17:12 <+ChillerDragon> matrix is so broken time to kill it again 17:14 <+bridge> [ddnet]