10:00 <+bridge> [ddnet] <ChillerDragon> @heinrich5991 so what about braces? Do we have a style guide for that?
10:53 <+bridge> [ddnet] <deen> always braces
10:54 <+bridge> [ddnet] <deen> even if it's not in a style guide
11:21 <+bridge> [ddnet] <ChillerDragon> i tried to enforce that in my mod when i started. but latley i found that no braces is easier to read and less lines. I think it is a style question. So ddnet code base wants braces always?
11:21 <+bridge> [ddnet] <ChillerDragon> a
11:21 <+bridge> [ddnet] <ChillerDragon> if (true) {
11:21 <+bridge> [ddnet] <ChillerDragon> // foo
11:21 <+bridge> [ddnet] <ChillerDragon> } else
11:22 <+bridge> [ddnet] <ChillerDragon> printf("bar");
11:22 <+bridge> [ddnet] <ChillerDragon> sorry for multiple lines but my client cant do it -.- uhm i think that is really ugly if the if has braces and the else doesnt
11:22 <+bridge> [ddnet] <ChillerDragon> but it is in ddnet code all over the place
11:51 <+bridge> [ddnet] <heinrich5991> definitely don't remove braces from code that has it, especially when you're not doing anything else with it
11:52 <+bridge> [ddnet] <heinrich5991> I prefer having braces everywhere, I will ask for braces if the other branch also has braces, or if we have a dangling else
11:59 <+bridge> [ddnet] <Jigglyfat> not having braces is cancer
12:00 <+bridge> [ddnet] <Jigglyfat> not having braces is cancer and inconsistent as hell mostly
13:21 <+bridge> [ddnet] <ChillerDragon> ok good to know so braces everywhere -.-
13:25 <+bridge> [ddnet] <ChillerDragon> oh and heinrich you mentioned this no style changes if you did no other changes multiple times now. I see it makes sense to have cleaner commit messages. But how are we going to improve the style then? I mean demo.cpp for example has even these javascript style braces with opening brace starts in same line as if. And this is really irritating while reading the code imo.
13:28 <+bridge> [ddnet] <ChillerDragon> we have 4175 if ( while ( and for (s .-.
13:28 <+bridge> [ddnet] <onby> or if its so short it doesnt need braces maybe u can use ternary
13:29 <+bridge> [ddnet] <ChillerDragon> yy sure but that is mostly not the case if u use normal people variables
13:30 <+bridge> [ddnet] <ChillerDragon> onbgy vars can always us tenary: a = bs ? fc : tt
13:30 <+bridge> [ddnet] <onby> 😂
13:30 <+bridge> [ddnet] <onby> ok good point
13:32 <+bridge> [ddnet] <ChillerDragon> i could even imagine u use braces for a new namespace because u run out of var names <2 characters xd
13:33 <+bridge> [ddnet] <onby> lmao
13:33 <+bridge> [ddnet] <onby> then i can start using undescores
13:33 <+bridge> [ddnet] <ChillerDragon> :troll:
13:33 <+bridge> [ddnet] <fokkonaut> Is this interesting for ddnet? I think no?
13:33 <+bridge> [ddnet] <fokkonaut> https://github.com/teeworlds/teeworlds/pull/2148
13:34 <+bridge> [ddnet] <ChillerDragon> nah weak is needed by maps
13:34 <+bridge> [ddnet] <onby> i got a slightly different fix by @qshar to remove weak hook and its generally been a good thing
13:34 <+bridge> [ddnet] <onby> idk how itd work on ddnet
13:34 <+bridge> [ddnet] <fokkonaut> How does qshar do it?
13:35 <+bridge> [ddnet] <onby> ill let him decide if its okay to post it here
13:35 <+bridge> [ddnet] <ChillerDragon> imo weak is a feature. In ddrace weak is used sometimes. And imo also in other gametypes like vanilla/block/fng giving a stronger who to the person who survived longer makes sense to me.
13:35 <+bridge> [ddnet] <heinrich5991> @onby weak hook was removed for a day until it was deemed map-breaking
13:35 <+bridge> [ddnet] <onby> oh
13:35 <+bridge> [ddnet] <fokkonaut> oh, okay
13:35 <+bridge> [ddnet] <ChillerDragon> sucks that they fix it in vanilla -.-
13:36 <+bridge> [ddnet] <fokkonaut> xd
13:36 <+bridge> [ddnet] <heinrich5991> it makes sense
13:36 <+bridge> [ddnet] <heinrich5991> it's a clear bug
13:36 <+bridge> [ddnet] <ChillerDragon> yes but it can be seens as ferature
13:36 <+bridge> [ddnet] <fokkonaut> If ddrace will ever be on 0.7 or higher we need to reimplement lots of bugs xD
13:36 <+bridge> [ddnet] <ChillerDragon> yes
13:36 <+bridge> [ddnet] <ChillerDragon> lol the issue is from Ubu o.O
13:37 <+bridge> [ddnet] <ChillerDragon> he was waiting 7 yrs for this pr haha
13:37 <+bridge> [ddnet] <heinrich5991> a lot of issues linger this long
13:37 <+bridge> [ddnet] <ChillerDragon> ikr
13:37 <+bridge> [ddnet] <heinrich5991> remember the date of the last actual release that wasn't just security fixes
13:38 <+bridge> [ddnet] <ChillerDragon> no
13:38 <+bridge> [ddnet] <ChillerDragon> xd
13:38 <+bridge> [ddnet] <ChillerDragon> it was before i was born
13:38 <+bridge> [ddnet] <ChillerDragon> if u look at 0.6
13:39 <+bridge> [ddnet] <ChillerDragon> so heinrich what about style in demo.cpp? are we planning to leave everything as it is until someone rewrites the whole file?
13:50 <+bridge> [ddnet] <qshar> I can search for a commit to remove week hook if you need, its not a secret of course
13:58 <+bridge> [ddnet] <deen> https://github.com/ddnet/ddnet/commit/2b084645276baa37b7a31aafa3fab0e3a323201b
13:59 <+bridge> [ddnet] <onby> that looks more like the fix i saw
13:59 <+bridge> [ddnet] <onby> does it have different results than the method fokkonot posted
14:07 <+bridge> [ddnet] <FluffiexD> deen
14:07 <+bridge> [ddnet] <FluffiexD> you copy pasted
14:07 <+bridge> [ddnet] <FluffiexD> from our mod
14:07 <+bridge> [ddnet] <FluffiexD> caught you
15:20 <+bridge> [ddnet] <n000b> @fokkonaut lol you should know this
15:30 <+bridge> [ddnet] <fokkonaut> what?
16:49 <+bridge> [ddnet] <n000b> The strong weak thing
17:03 <+bridge> [ddnet] <fokkonaut> ?
17:04 <+bridge> [ddnet] <fokkonaut> I just sent a link of the pr in vanills
17:04 <+bridge> [ddnet] <ChillerDragon> i guess n0b0 means that you should know that missing weak breaks maps since you are a expirenced player @fokkonaut
17:05 <+bridge> [ddnet] <fokkonaut> Ah
17:05 <+bridge> [ddnet] <fokkonaut> yea
17:20 <+bridge> [ddnet] <n000b> Yup
17:20 <+bridge> [ddnet] <n000b> Sorry i wasnt clear enough😬
22:14 <+bridge> [ddnet] <ChillerDragon> uhm @fokkonaut was there a knownn bug with shiftes names?
22:15 <+bridge> [ddnet] <ChillerDragon> 
22:15 <+bridge> [ddnet] <ChillerDragon> https://cdn.discordapp.com/attachments/293493549758939136/586287006133518336/screenshot_2019-06-06_22-15-00.png
22:15 <+bridge> [ddnet] <archimede67> ja
22:15 <+bridge> [ddnet] <ChillerDragon> ah k
22:15 <+bridge> [ddnet] <archimede67> https://github.com/ddnet/ddnet/issues/1752
22:16 <+bridge> [ddnet] <fokkonaut> @Jupstar ✪ seems like its not always starting in the tee center
22:17 <+bridge> [ddnet] <fokkonaut> look at Pfandflasche
22:17 <+bridge> [ddnet] <ChillerDragon> woudlt call 20 min long
22:17 <+bridge> [ddnet] <archimede67> how
22:17 <+bridge> [ddnet] <archimede67> 
22:17 <+bridge> [ddnet] <archimede67> https://cdn.discordapp.com/attachments/293493549758939136/586287550461771790/unknown.png
22:17 <+bridge> [ddnet] <archimede67> this is not 20 mins xd
22:17 <+bridge> [ddnet] <ChillerDragon> ah its 22
22:17 <+bridge> [ddnet] <ChillerDragon> 22:17
22:18 <+bridge> [ddnet] <ChillerDragon> xd
22:18 <+bridge> [ddnet] <archimede67> how
22:18 <+bridge> [ddnet] <fokkonaut> is it 36 min race time or play time?
22:18 <+bridge> [ddnet] <ChillerDragon> time in germany
22:18 <+bridge> [ddnet] <ChillerDragon> xd
22:18 <+bridge> [ddnet] <fokkonaut> what does Played sas?
22:18 <+bridge> [ddnet] <fokkonaut> say*
22:18 <+bridge> [ddnet] <archimede67> how can u play less than ur race time
22:18 <+bridge> [ddnet] <ChillerDragon> i thouight its played
22:18 <+bridge> [ddnet] <ChillerDragon> but my client is so old it only shows the clock
22:18 <+bridge> [ddnet] <ChillerDragon> 22:18 european time
22:18 <+bridge> [ddnet] <ChillerDragon> xd
22:18 <+bridge> [ddnet] <ChillerDragon> i red wrong
22:19 <+bridge> [ddnet] <ChillerDragon> its more than 30 min all fine xd
22:19 <+bridge> [ddnet] <archimede67> ???? xd
22:22 <+bridge> [ddnet] <ChillerDragon> im not as good with numbers as u @archimede67
22:22 <+bridge> [ddnet] <archimede67> xd
22:23 <+bridge> [ddnet] <ChillerDragon> http://puu.sh/DCyHQ/00fe75fcee.jpg
22:29 <+bridge> [ddnet] <Jupstar ✪> @fokkonaut is centered for me
22:29 <+bridge> [ddnet] <Jupstar ✪> maybe not the newest client?
22:29 <+bridge> [ddnet] <ChillerDragon> its 1 tee
22:30 <+bridge> [ddnet] <Jupstar ✪> yeah but still, newest client?
22:30 <+bridge> [ddnet] <ChillerDragon> no
22:30 <+bridge> [ddnet] <Jupstar ✪> ah
22:41 <+bridge> [ddnet] <fokkonaut> @Jupstar ✪ Pfandflasche is not centered xd
22:47 <+bridge> [ddnet] <Jupstar ✪> @fokkonaut it is for me
22:47 <+bridge> [ddnet] <Jupstar ✪> and he uses old client
22:48 <+bridge> [ddnet] <Jupstar ✪> its not the same bug like urs.. urs might not even be a bug in terms of coding, but an overflow or something like that
22:48 <+bridge> [ddnet] <fokkonaut> 
22:48 <+bridge> [ddnet] <fokkonaut> https://cdn.discordapp.com/attachments/293493549758939136/586295438358085643/20190606_224832.jpg
22:48 <+bridge> [ddnet] <Jupstar ✪> bcs its pretty impossible to reproduce
22:48 <+bridge> [ddnet] <Jupstar ✪> dude
22:48 <+bridge> [ddnet] <Jupstar ✪> stop ignoring
22:49 <+bridge> [ddnet] <ChillerDragon> fokko :troll:
22:49 <+bridge> [ddnet] <fokkonaut> Im just saying this is not centered
22:49 <+bridge> [ddnet] <archimede67> its not centered at all xd
22:49 <+bridge> [ddnet] <Jupstar ✪> its an old client
22:49 <+bridge> [ddnet] <archimede67> yeah
22:49 <+bridge> [ddnet] <ChillerDragon> @Jupstar ✪ its not in the middle
22:49 <+bridge> [ddnet] <Jupstar ✪> @archimede67 even posted the fix
22:49 <+bridge> [ddnet] <archimede67> @ChillerDragon stop playing on old
22:49 <+bridge> [ddnet] <archimede67> u nobo
22:50 <+bridge> [ddnet] <ChillerDragon> lehgacy swagger
22:50 <+bridge> [ddnet] <jao> chiller reporting fixed bugs 👌
22:50 <+bridge> [ddnet] <fokkonaut> :lol:
22:50 <+bridge> [ddnet] <ChillerDragon> boi i pinged fokko because i wasnt sure if its reported already -.-
22:51 <+bridge> [ddnet] <jao> reminds me of your mute "fix"
22:51 <+bridge> [ddnet] <ChillerDragon> xd
22:51 <+bridge> [ddnet] <archimede67> 😂
22:52 <+bridge> [ddnet] <ChillerDragon> i have the feeling jao doesnt forget that -.-
22:53 <+bridge> [ddnet] <jao> every time you complain about bugs I will remember it
22:54 <+bridge> [ddnet] <ChillerDragon> mute was clearly a feature
22:54 <+bridge> [ddnet] <texnonik> why i had one day in editor so many crashes ?
22:54 <+bridge> [ddnet] <ChillerDragon> latest version?
22:54 <+bridge> [ddnet] <ChillerDragon> see thats why im not updating
22:55 <+bridge> [ddnet] <ChillerDragon> crashes in editor sukk -.-
22:55 <+bridge> [ddnet] <jao> best bug report
22:55 <+bridge> [ddnet] <archimede67> 👌
22:55 <+bridge> [ddnet] <texnonik> but in last version they fixed some stuped bugs and created new stuff
22:56 <+bridge> [ddnet] <jao> stuped
22:56 <+bridge> [ddnet] <texnonik> but in last version they fixed some stupet bugs and created new stuff
22:56 <+bridge> [ddnet] <ChillerDragon> how to reproduce @texnonik
22:56 <+bridge> [ddnet] <texnonik> kms ?
22:56 <+bridge> [ddnet] <texnonik> kms ¿
22:56 <+bridge> [ddnet] <archimede67> @ChillerDragon you will need to update if you want the replays feature 😄
22:56 <+bridge> [ddnet] <ChillerDragon> no edit in developer pls
22:57 <+bridge> [ddnet] <jao> stupet
22:57 <+bridge> [ddnet] <ChillerDragon> cherry pick git magic @archimede67
22:57 <+bridge> [ddnet] <archimede67> 😄
22:57 <+bridge> [ddnet] <texnonik> but in last version they fixed some bad bugs and created new stuff
22:57 <+bridge> [ddnet] <texnonik> :feelsamazingman:
22:57 <+bridge> [ddnet] <ChillerDragon> into good ol ddnet 6 client
22:58 <+bridge> [ddnet] <texnonik> first version of ddnet ♥ 😄
22:58 <+bridge> [ddnet] <texnonik> first version of ddnet ♥ :troll:
22:59 <+bridge> [ddnet] <jao> @texnonik what did you do before crashing editor
23:01 <+bridge> [ddnet] <texnonik> zoom out a bit and release after mouse 1 and crashed , at least i save after i do somethink , i didn't lose progress
23:01 <+bridge> [ddnet] <texnonik> 
23:01 <+bridge> [ddnet] <texnonik> https://cdn.discordapp.com/attachments/293493549758939136/586298739778519060/unknown.png
23:02 <+bridge> [ddnet] <archimede67> are you sure you have the latest version?
23:02 <+bridge> [ddnet] <texnonik> yes
23:02 <+bridge> [ddnet] <archimede67> tell me the version
23:02 <+bridge> [ddnet] <texnonik> is there a txt bug report ?
23:03 <+bridge> [ddnet] <texnonik> https://gyazo.com/cc2cf5bd65faa6049c9fdfe0078a69a8
23:03 <+bridge> [ddnet] <archimede67> strange
23:03 <+bridge> [ddnet] <jao> zoom makes a difference?
23:04 <+bridge> [ddnet] <jao> can't reproduce
23:04 <+bridge> [ddnet] <archimede67> me neither
23:04 <+bridge> [ddnet] <jao> can you do it consistently
23:05 <+bridge> [ddnet] <texnonik> ohhhh i remember i also was spectating someone in game ...
23:05 <+bridge> [ddnet] <archimede67> did you have a tile selected also
23:06 <+bridge> [ddnet] <jao> there was a bug with this but it should be fixed in latest ver
23:06 <+bridge> [ddnet] <archimede67> yeah
23:08 <+bridge> [ddnet] <texnonik> i found demo xD
23:09 <+bridge> [ddnet] <ChillerDragon> dont think that it helps xd
23:10 <+bridge> [ddnet] <texnonik> 
23:10 <+bridge> [ddnet] <texnonik> https://cdn.discordapp.com/attachments/293493549758939136/586300897429029010/Aim_10.0_2019-06-01_18-35-08.demo
23:10 <+bridge> [ddnet] <texnonik> 😦
23:10 <+bridge> [ddnet] <texnonik> https://cdn.discordapp.com/attachments/293493549758939136/586300970439278611/Aim_10.0_2019-06-01_18-25-31.demo
23:11 <+bridge> [ddnet] <texnonik> lol 1st demo i crashed editor in 30 seconds 😄
23:11 <+bridge> [ddnet] <archimede67> what do you want us to do with that??
23:12 <+bridge> [ddnet] <ChillerDragon> dont be mean @archimede67
23:12 <+bridge> [ddnet] <archimede67> nah but how can a demo help as it doesn't record editor
23:12 <+bridge> [ddnet] <ChillerDragon> men he tried
23:12 <+bridge> [ddnet] <archimede67> xd