12:24 <+ddnet-discord> uhm does some1 knows how these github reviews work? 12:25 <+ddnet-discord> some1 wrote some comments to my code and i responeded but its invisible if im not logged in 12:26 <+ddnet-discord> it looks like this while being logged out: 12:26 <+ddnet-discord> 12:26 <+ddnet-discord> https://cdn.discordapp.com/attachments/293493549758939136/398799341940113428/Bildschirmfoto_2018-01-05_um_12.25.16.png 12:26 <+ddnet-discord> but for me logged in i see my response: 12:26 <+ddnet-discord> 12:26 <+ddnet-discord> https://cdn.discordapp.com/attachments/293493549758939136/398799393979105280/Bildschirmfoto_2018-01-05_um_12.25.30.png 12:29 <+ddnet-discord> pending 12:29 <+ddnet-discord> probably 12:29 <+ddnet-discord> maybe someone has to accept it, or you have to 12:29 <+ddnet-discord> xD 12:49 <+ddnet-discord> ?????? 12:49 <+ddnet-discord> i just commented a comment 12:49 <+ddnet-discord> on my own pr 12:51 <+ddnet-discord> ?! ?!!?! ?! ? 13:06 <+ddnet-discord> you probably started a review instead of adding single comments 13:06 <+ddnet-discord> https://help.github.com/articles/reviewing-proposed-changes-in-a-pull-request/#submitting-your-review 13:10 <+ddnet-discord> login, right reply below my comments and press 'comment' 13:10 <+ddnet-discord> login, reply below my comments and press 'comment' 14:42 <+ddnet-discord> @heinrich5991 I just randomly stumbled upon a comment from you: https://stackoverflow.com/questions/426230/what-is-the-ld-preload-trick 14:42 <+ddnet-discord> 🙂 15:37 < ddnet-commits> [ddnet] Ryozuki opened pull request #977: Active moderator mode (master...pr_moderate_cmd) https://git.io/vNJxA 15:55 <+ddnet-discord> @ChillerDragon you need to click "finish review" or something 15:58 <+ddnet-discord> "pending" means that it hasn't been sent yet 16:01 < ddnet-commits> [ddnet] heinrich5991 opened pull request #978: Disable warnings for GTest (master...pr_ddnet_gtest_no_warnings) https://git.io/vNJjV 16:08 < ddnet-commits> [ddnet] heinrich5991 opened pull request #979: Add a missing call to `lock_wait` in test function (master...pr_ddnet_test_missing_thread_lock) https://git.io/vNUe8 16:14 <+ddnet-discord> @Learath2 does aio still crash for you? 16:14 <+ddnet-discord> can't reproduce ATM 16:19 <+ddnet-discord> You never could reproduce it 16:19 <+ddnet-discord> Will check when im hom 16:21 <+ddnet-discord> I was able to reproduce it once I think 16:21 <+ddnet-discord> in the tests 17:33 <+Chairn> Hello 17:33 <+Chairn> How do you compile ddnet now? 17:33 <+ddnet-discord> allo 17:33 <+Chairn> I've seen that bam isn't needed anymore 17:33 <+ddnet-discord> bam or cmake 17:33 <+Chairn> was there an update on bam? 17:34 <+Chairn> i got this error with bam: configure.lua:109: there is no configuration option named 'opus' bam.exe: script error (-t for more detail) 17:34 <+Chairn> configure.lua:109: there is no configuration option named 'opus' backtrace: configure.lua(109): (null) config.lua(20): options_func local configure.lua(115): Load method configure.lua(187): Finalize method bam.lua(35): (null) bam.exe: script error (-t for more detail) 17:35 <+ddnet-discord> i'm using bam 0.5.0, you? 17:36 <+Chairn> 0.4.x 17:36 <+Chairn> so there was an update 17:36 <+ddnet-discord> try 0.5 17:39 <+ddnet-discord> ty @saibotu and @heinrich5991 i managed it to reply a comment^^ 17:42 <+Chairn> hum, still the same error 17:42 <+Chairn> configure.lua:109: there is no configuration option named 'opus' backtrace: configure.lua(109): __index metamethod config.lua(20): options_func local configure.lua(115): Load method configure.lua(187): Finalize method bam.lua(35): (null) bam.exe: script error (-t for more detail) 17:42 <+Chairn> bam version 0.5.0 using Lua 5.3.3 17:44 <+ddnet-discord> `bam -c config` 17:44 <+ddnet-discord> (or try deleting `config.lua`) 17:44 <+ddnet-discord> afk 17:44 <+ddnet-discord> seems to work now 17:45 <+ddnet-discord> also, try cmake 😉 17:45 <+ddnet-discord> well compile has errors now 17:45 <+ddnet-discord> i'll check taht later 17:46 <+ddnet-discord> Migrate to cmake before we nuke bam 18:15 <+ddnet-discord> >ban Konsti 18:15 <+ddnet-discord> >unban Konsti 18:26 <+ddnet-discord> >reban Konsti 18:26 <+ddnet-discord> >unban Konsti 18:26 <+ddnet-discord> >ban ezy 18:26 <+ddnet-discord> >fuck you 18:27 <+ddnet-discord> >k 18:27 <+ddnet-discord> >in the ass 18:27 <+ddnet-discord> >dont have one 18:28 <+ddnet-discord> stop sppam 18:29 <+ddnet-discord> >stop sppam 18:30 <+ddnet-discord> >start spread spperm 18:39 <+ddnet-discord> ?purge 11 18:39 <+ddnet-discord> >mod abuse 20:18 < ddnet-commits> [ddnet] def- pushed 3 new commits to master: https://git.io/vNUga 20:18 < ddnet-commits> ddnet/master 3025ed3 def: Introduce cl_show_chat_system... 20:18 < ddnet-commits> ddnet/master f1af7cf def: Still render chat input even when chat is disabled 20:18 < ddnet-commits> ddnet/master 77a999c def: Add cl_showemotes 20:20 < ddnet-commits> [ddnet] def- pushed 1 new commit to master: https://git.io/vNUgF 20:20 < ddnet-commits> ddnet/master 4813a4b def: Add cl_shownotifications (fixes #949)