10:08 < ddnet-commits> [ddnet] Ryozuki opened pull request #739: Don't show ips to non-administrators, fixes #694 (master...pr_hide_ip_nonadmin) https://git.io/vSHy9
12:03 < grenadepro> hi
12:03 < grenadepro> check this line : https://github.com/ddnet/ddnet/blob/master/src/game/server/player.cpp#L67
12:03 < grenadepro> how this possible "g_Config.m_SvDefaultTimerType == CPlayer::TIMERTYPE_GAMETIMER_AND_BROADCAST"
12:04 < grenadepro> when you have this https://github.com/ddnet/ddnet/blob/master/src/engine/shared/config_variables.h#L340
12:05 <@EastByte> what's wrong?
12:06 < grenadepro> svdefaulttimertype cant be 2
12:06 < grenadepro> https://github.com/ddnet/ddnet/blob/master/src/game/server/player.h#L147
12:06 < grenadepro> sv_default_timer_type, 0, 0, 1
12:07 < grenadepro> so its useless
12:08 < grenadepro> maybe im wrong ?
12:08 <@EastByte> yea, looks like the conf var itself doesn't support TIMERTYPE_GAMETIMER_AND_BROADCAST
12:09 <@EastByte> necropotame: u there?
12:10 < grenadepro> player.cpp#L67 could be "m_TimerType = g_Config.m_SvDefaultTimerType == CPlayer::TIMERTYPE_GAMETIMER ? g_Config.m_SvDefaultTimerType : CPlayer::TIMERTYPE_BROADCAST;"
13:18 < necropotame> EastByte, I've not followed the discussion. Do you need something?
13:19 <@EastByte> https://github.com/ddnet/ddnet/blob/master/src/game/server/player.cpp#L67 SvDefaultTimerType is expected to be TIMERTYPE_GAMETIMER or TIMERTYPE_GAMETIMER_AND_BROADCAST
13:20 <@EastByte> but TIMERTYPE_GAMETIMER_AND_BROADCAST isn't within the range of the conf variable
13:20 <@EastByte> https://github.com/ddnet/ddnet/blob/master/src/engine/shared/config_variables.h#L340
13:21 <@EastByte> enum defined here: https://github.com/ddnet/ddnet/blob/master/src/game/server/player.h#L147
13:21 < necropotame> Oh true
13:22 < necropotame> I don't have the time to fix it now
13:22 <@EastByte> no problem
21:19 < DanilBest> hi
21:36 <@deen> hi bye DanilBest
21:37 < Ryozuki> :/